From: Junio C Hamano <gitster@pobox.com>
To: Dominique Martinet <asmadeus@codewreck.org>
Cc: git@vger.kernel.org, "René Scharfe" <l.s.r@web.de>,
"Julien Moutinho" <julm@sourcephile.fr>
Subject: Re: [RFC PATCH] builtin/format-patch: print a warning for skipped merge commits?
Date: Wed, 31 Dec 2025 14:12:07 +0900 [thread overview]
Message-ID: <xmqqo6nfdyl4.fsf@gitster.g> (raw)
In-Reply-To: <20251231034217.2498648-1-asmadeus@codewreck.org> (Dominique Martinet's message of "Wed, 31 Dec 2025 12:42:17 +0900")
Dominique Martinet <asmadeus@codewreck.org> writes:
> This RFC patch illustrates how we could easily print a warning, but
> perhaps the warning would only make sense if no other commit has been
> formatted?
Yeah, when nothing is shown but the given range is not empty, it
would not be too annoying to give an advice message.
On the other hand, I do not think it is a good idea to say anything
extra when the user gave a range "trunk..mytopic" that has repeated
back-merges from trunk into mytopic, to format what s/he worked on
the mytopic branch. They _expect_ these back-merges to be ignored,
and it would be purely an unwanted noise.
Thanks.
prev parent reply other threads:[~2025-12-31 5:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-31 3:42 [RFC PATCH] builtin/format-patch: print a warning for skipped merge commits? Dominique Martinet
2025-12-31 5:12 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo6nfdyl4.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=asmadeus@codewreck.org \
--cc=git@vger.kernel.org \
--cc=julm@sourcephile.fr \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).