git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] GitHub CI: macos-13 images are no more
@ 2025-11-04 23:13 Junio C Hamano
  2025-11-05 14:34 ` Junio C Hamano
  0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2025-11-04 23:13 UTC (permalink / raw)
  To: git

As this image was deprecated on Sep 22nd, and will be dropped on Dec
4th, replace these jobs to use macos-14 images instead.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

 * This is a monkey-see-monkey-do patch.  There may be additional
   adjustment necessary (versions of tools available on the system
   may be different, for example).

 .github/workflows/main.yml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index aa6bce673b..f2af90ad31 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -313,16 +313,16 @@ jobs:
         vector:
           - jobname: osx-clang
             cc: clang
-            pool: macos-13
+            pool: macos-14
           - jobname: osx-reftable
             cc: clang
-            pool: macos-13
+            pool: macos-14
           - jobname: osx-gcc
             cc: gcc-13
-            pool: macos-13
+            pool: macos-14
           - jobname: osx-meson
             cc: clang
-            pool: macos-13
+            pool: macos-14
     env:
       CC: ${{matrix.vector.cc}}
       CC_PACKAGE: ${{matrix.vector.cc_package}}
-- 
2.52.0-rc0-105-gc08128fbb6


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] GitHub CI: macos-13 images are no more
  2025-11-04 23:13 [PATCH] GitHub CI: macos-13 images are no more Junio C Hamano
@ 2025-11-05 14:34 ` Junio C Hamano
  2025-11-06  7:14   ` Patrick Steinhardt
  0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2025-11-05 14:34 UTC (permalink / raw)
  To: git

Junio C Hamano <gitster@pobox.com> writes:

> As this image was deprecated on Sep 22nd, and will be dropped on Dec
> 4th, replace these jobs to use macos-14 images instead.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>
>  * This is a monkey-see-monkey-do patch.  There may be additional
>    adjustment necessary (versions of tools available on the system
>    may be different, for example).

This, when test-merged to 'master' and also to 'next', seems to be
enough to get GitHub Actions based CI pass.  I'll fast-track it in
order to allow us to run it with the upcoming -rc1, and eventually
down to 'maint',

>  .github/workflows/main.yml | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index aa6bce673b..f2af90ad31 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> @@ -313,16 +313,16 @@ jobs:
>          vector:
>            - jobname: osx-clang
>              cc: clang
> -            pool: macos-13
> +            pool: macos-14
>            - jobname: osx-reftable
>              cc: clang
> -            pool: macos-13
> +            pool: macos-14
>            - jobname: osx-gcc
>              cc: gcc-13
> -            pool: macos-13
> +            pool: macos-14
>            - jobname: osx-meson
>              cc: clang
> -            pool: macos-13
> +            pool: macos-14
>      env:
>        CC: ${{matrix.vector.cc}}
>        CC_PACKAGE: ${{matrix.vector.cc_package}}

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] GitHub CI: macos-13 images are no more
  2025-11-05 14:34 ` Junio C Hamano
@ 2025-11-06  7:14   ` Patrick Steinhardt
  0 siblings, 0 replies; 3+ messages in thread
From: Patrick Steinhardt @ 2025-11-06  7:14 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

On Wed, Nov 05, 2025 at 06:34:30AM -0800, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> 
> > As this image was deprecated on Sep 22nd, and will be dropped on Dec
> > 4th, replace these jobs to use macos-14 images instead.
> >
> > Signed-off-by: Junio C Hamano <gitster@pobox.com>
> > ---
> >
> >  * This is a monkey-see-monkey-do patch.  There may be additional
> >    adjustment necessary (versions of tools available on the system
> >    may be different, for example).
> 
> This, when test-merged to 'master' and also to 'next', seems to be
> enough to get GitHub Actions based CI pass.  I'll fast-track it in
> order to allow us to run it with the upcoming -rc1, and eventually
> down to 'maint',

Makes sense. I don't really expect any fallout from this -- GitLab CI
has been using macOS 14 for a while already, and I never noticed any
issues with it.

Could of course be that GitHub does anything special here, but I guess
that a green pipeline is confirmation enough.

Thanks!

Patrick

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-11-06  7:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-04 23:13 [PATCH] GitHub CI: macos-13 images are no more Junio C Hamano
2025-11-05 14:34 ` Junio C Hamano
2025-11-06  7:14   ` Patrick Steinhardt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).