From: Junio C Hamano <gitster@pobox.com>
To: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] [Outreachy] patch-ids: fix const correctness
Date: Mon, 13 Oct 2025 11:33:39 -0700 [thread overview]
Message-ID: <xmqqo6qa1wjg.fsf@gitster.g> (raw)
In-Reply-To: <CAFpMFfAHA8OfVXKVVSSAQ5p+B8ngT3p54on1HpM+n2qs3P1rHA@mail.gmail.com> (Okhuomon Ajayi's message of "Mon, 13 Oct 2025 19:14:47 +0100")
Okhuomon Ajayi <okhuomonajayi54@gmail.com> writes:
> Thanks for explaining! I get it now the NEEDSWORK comment isn’t needed
> since the hashmap API is supposed to have cmpfn_data as const. I’ve
> removed the comment and didn’t change anything else
The NEEDSWORK comment is about going even further, starting from
question if hashmap should really be using "const" in the first
place, to sort things out among all the components involved
(including other users of the hashmap API).
A commit that does not do the necessary study and just removes the
needswork comment is simply irresponsible, no?
next prev parent reply other threads:[~2025-10-13 18:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 16:53 [PATCH] [Outreachy] patch-ids: fix const correctness Okhuomon Ajayi
2025-10-13 17:12 ` Junio C Hamano
2025-10-13 17:22 ` Okhuomon Ajayi
2025-10-13 17:29 ` Junio C Hamano
2025-10-13 18:14 ` Okhuomon Ajayi
2025-10-13 18:33 ` Junio C Hamano [this message]
2025-10-13 21:55 ` Okhuomon Ajayi
-- strict thread matches above, loose matches on Subject: below --
2025-10-09 21:44 Okhuomon Ajayi
2025-10-09 21:46 ` Kristoffer Haugsbakk
2025-10-10 0:45 ` Junio C Hamano
2025-10-09 21:57 ` Okhuomon Ajayi
2025-10-09 23:49 ` Agatha Isabelle
2025-10-10 0:13 ` Okhuomon Ajayi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo6qa1wjg.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=okhuomonajayi54@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).