git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Philippe Blain <levraiphilippeblain@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>,  git@vger.kernel.org
Subject: Re: What's cooking in git.git (Apr 2025, #01; Mon, 7)
Date: Wed, 09 Apr 2025 08:59:53 -0700	[thread overview]
Message-ID: <xmqqo6x5s4ue.fsf@gitster.g> (raw)
In-Reply-To: <d5588a3d-db07-5c4e-3c22-ad4b751dd3fc@gmail.com> (Philippe Blain's message of "Wed, 9 Apr 2025 07:31:03 -0400")

Philippe Blain <levraiphilippeblain@gmail.com> writes:

>>> I had one question around empty prereqs introduced by the patch that
>>> wasn't yet answered. Based on my testing empty prereqs do work just fine
>>> though and evaluate to true, so the patch series looks fine to me.
>
> Patrick, thank you for your review on this series, and for testing it.
> I do intend to answer you in that thread, and I also wanted to actually test
> what you mentioned about empty prereqs, I just have very limited time to
> contribute these days, so I don't know when I'll be able to.

Yup, thanks both of you.

> Junio, I see this was merged to 'next' already yesterday (the 8th), and
> you sent this "What's cooking" on the 7th. Would it be possible to wait 
> more than one day before announcing an upcoming merge to 'next' of a series
> and the actual merge ? This would allow contributors with very little time
> to contribute a little more time to say so if they wish to wait 
> before merging to next because they want to send a new iteration. 

I know the frustration.  But this is team-work; even if you are
somewhat unsure about certain details of your own change, others
(like Patrick in this case) can help you.

Instead of offering to slow down (say, wait for 3 days after marking
a topic for 'next'), I can say I'll be more careful before I mark a
topic as such.  As the former will inevitably invite "so how many
days is long enough?", whose answer depends on who you ask, and I do
not have enough bandwidth to keep track of how fast a response I
should expect from each contributor.  Two things you can do to help
are to accompany a new iteration you send with some comments like

 (1) "I am unsure about this and that aspects of this patch (yet)",
     to help others help you and the community to convince ourselves
     of these parts that you were unsure about, or simply improve on
     your work.

 (2) "I will be slow, so unless there is capable somebody else who
     can champion this patch without me, please wait before I can
     also say I am happy with this iteration", to allow others to
     either go without you (and take responsibility of the outcome)
     or wait for you.

perhaps?


  reply	other threads:[~2025-04-09 15:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 16:49 What's cooking in git.git (Apr 2025, #01; Mon, 7) Junio C Hamano
2025-04-08  6:22 ` Patrick Steinhardt
2025-04-08 14:50   ` Junio C Hamano
2025-04-09 11:31     ` Philippe Blain
2025-04-09 15:59       ` Junio C Hamano [this message]
2025-04-08  8:20 ` Karthik Nayak
2025-04-09 11:24 ` Philippe Blain
2025-04-09 16:01   ` Junio C Hamano
2025-06-05 12:51   ` Junio C Hamano
2025-06-05 15:10     ` Philippe Blain
2025-06-05 18:29       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo6x5s4ue.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=levraiphilippeblain@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).