From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Benjamin Woodruff via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Benjamin Woodruff <github@benjam.info>
Subject: Re: [PATCH 0/2] describe and diff: implement --no-optional-locks
Date: Mon, 10 Mar 2025 11:53:54 -0700 [thread overview]
Message-ID: <xmqqo6y87m4d.fsf@gitster.g> (raw)
In-Reply-To: <20250310160837.GA26308@coredump.intra.peff.net> (Jeff King's message of "Mon, 10 Mar 2025 12:08:37 -0400")
Jeff King <peff@peff.net> writes:
> But maybe that is lost in the noise of reading the files to actually do
> diffs, etc? I dunno. I expect it is more important for status, which
> probably does not need to read the whole file contents in most cases
> (and which may be run a lot from the user's prompt, etc).
Yeah, and old timers who run "diff --raw" as if it were a quick
analogue for "status" also would notice.
> It seems like a big and possibly risky departure from what we've done
> for so many years. I'm inclined not to rock the boat too much. ;)
Certainly not right now. But adding a command line option is even
worse as we would have to carry the support for it for practically
forever X-<.
next prev parent reply other threads:[~2025-03-10 18:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 5:58 [PATCH 0/2] describe and diff: implement --no-optional-locks Benjamin Woodruff via GitGitGadget
2025-03-06 5:58 ` [PATCH 1/2] describe: " Benjamin Woodruff via GitGitGadget
2025-03-06 5:58 ` [PATCH 2/2] diff: " Benjamin Woodruff via GitGitGadget
2025-03-06 16:11 ` [PATCH 0/2] describe and " Junio C Hamano
2025-03-09 3:39 ` Jeff King
2025-03-10 12:25 ` Junio C Hamano
2025-03-10 16:08 ` Jeff King
2025-03-10 18:53 ` Junio C Hamano [this message]
2025-03-10 20:50 ` Benjamin Woodruff
2025-03-10 23:04 ` Junio C Hamano
2025-03-11 2:10 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo6y87m4d.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=github@benjam.info \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).