From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Peter Oliver <p.d.oliver@mavit.org.uk>,
git@vger.kernel.org, Peter Oliver <git@mavit.org.uk>
Subject: Re: [PATCH v3 0/2] Fix Meson Perl version check
Date: Wed, 19 Feb 2025 08:05:04 -0800 [thread overview]
Message-ID: <xmqqo6yxhqdr.fsf@gitster.g> (raw)
In-Reply-To: <Z7WFpu6QEBJXwAIH@pks.im> (Patrick Steinhardt's message of "Wed, 19 Feb 2025 08:17:58 +0100")
Patrick Steinhardt <ps@pks.im> writes:
> On Tue, Feb 18, 2025 at 11:12:03AM -0800, Junio C Hamano wrote:
>> Peter Oliver <p.d.oliver@mavit.org.uk> writes:
>>
>> > Suggested comments added.
>> >
>> > Peter Oliver (2):
>> > meson: bump minimum required Perl version to 5.26.0
>> > meson: fix Perl version check for Meson versions before 1.7.0
>> >
>> > meson.build | 17 ++++++++++++++++-
>> > 1 file changed, 16 insertions(+), 1 deletion(-)
>>
>> I wasn't involved in the review of the previous rounds (so it was a
>> bit of surprise for me to be listed on the To: line), but it seems
>> that Patrick and you polished these two together, so I'll see if I
>> can add Patrick's acked-by/reviewed-by while queuing by waiting for
>> the earth to turn one rotation.
>
> Yup, this version looks good to me, thanks Peter. So please feel free to
> add either my Acked-by or Reviewed-by, I'd be fine with either.
Thanks for working well together. Let me mark the topic for 'next'.
next prev parent reply other threads:[~2025-02-19 16:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 16:03 [PATCH 1/2] Check for Perl 5.26.0 from Meson build Peter Oliver
2025-01-20 16:03 ` [PATCH 2/2] Fix Meson Perl version check Peter Oliver
2025-01-21 6:44 ` Patrick Steinhardt
2025-01-21 6:44 ` [PATCH 1/2] Check for Perl 5.26.0 from Meson build Patrick Steinhardt
2025-01-24 16:30 ` [PATCH v2 0/2] Fix Meson Perl version check Peter Oliver
2025-01-24 16:30 ` [PATCH v2 1/2] meson: bump minimum required Perl version to 5.26.0 Peter Oliver
2025-01-24 16:30 ` [PATCH v2 2/2] meson: fix Perl version check for Meson versions before 1.7.0 Peter Oliver
2025-01-27 7:39 ` Patrick Steinhardt
2025-02-18 15:30 ` [PATCH v3 0/2] Fix Meson Perl version check Peter Oliver
2025-02-18 15:30 ` [PATCH v3 1/2] meson: bump minimum required Perl version to 5.26.0 Peter Oliver
2025-02-18 15:30 ` [PATCH v3 2/2] meson: fix Perl version check for Meson versions before 1.7.0 Peter Oliver
2025-02-18 19:12 ` [PATCH v3 0/2] Fix Meson Perl version check Junio C Hamano
2025-02-19 7:17 ` Patrick Steinhardt
2025-02-19 16:05 ` Junio C Hamano [this message]
2025-02-25 12:28 ` Peter Oliver
2025-02-25 18:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo6yxhqdr.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@mavit.org.uk \
--cc=git@vger.kernel.org \
--cc=p.d.oliver@mavit.org.uk \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).