public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: "Matěj Cepl" <mcepl@cepl.eu>, git@vger.kernel.org
Subject: Re: [PATCH] doc: fix typo
Date: Tue, 18 Feb 2025 10:51:10 -0800	[thread overview]
Message-ID: <xmqqo6yzkrxd.fsf@gitster.g> (raw)
In-Reply-To: <Z7QszEnV4EzQMJ9R@pks.im> (Patrick Steinhardt's message of "Tue, 18 Feb 2025 07:46:36 +0100")

Patrick Steinhardt <ps@pks.im> writes:

> You should probably rebase your commit on the latest `master` as the
> file has since been renamed to "git-send-email.adoc".

This looks like a 'maint' worthy material, though.

Downporting with cherry-pick should be able to deal with the rename,
but queuing with the old name on an older maintenance track and
upmerging should be cleaner, so .txt is fine in this case.

Not that I plan to do Git 2.48.2 anytime soon, so either way it does
not really matter, though ;-)

Thanks for a review.


>> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
>> index bc3ef45acb..d762058907 100644
>> --- a/Documentation/git-send-email.txt
>> +++ b/Documentation/git-send-email.txt
>> @@ -389,7 +389,7 @@ Automating
>>  +
>>  Default is the value of `sendemail.suppressCc` configuration value; if
>>  that is unspecified, default to 'self' if --suppress-from is
>> -specified, as well as 'body' if --no-signed-off-cc is specified.
>> +specified, as well as 'body' if --no-signed-off-by-cc is specified.
>
> The change itself looks obviously correct to me, thanks!
>
> Patrick

  reply	other threads:[~2025-02-18 18:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-17 13:08 [PATCH] doc: fix typo Matěj Cepl
2025-02-18  6:46 ` Patrick Steinhardt
2025-02-18 18:51   ` Junio C Hamano [this message]
2025-02-19  8:06     ` Matěj Cepl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo6yzkrxd.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mcepl@cepl.eu \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox