From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "D. Ben Knoble" <ben.knoble@gmail.com>,
Askar Safin <safinaskar@zohomail.com>,
git <git@vger.kernel.org>
Subject: Re: [bug] "git bisect old v3.0" takes 21 mins on Linux repo
Date: Thu, 16 Jan 2025 08:40:19 -0800 [thread overview]
Message-ID: <xmqqo706u2z0.fsf@gitster.g> (raw)
In-Reply-To: <20250116135227.GA2323616@coredump.intra.peff.net> (Jeff King's message of "Thu, 16 Jan 2025 08:52:27 -0500")
Jeff King <peff@peff.net> writes:
> Oh nevermind, that won't work, as it double-counts commits that are
> reachable from each parent. Still, it feels like there ought to be a way
> to compute it with a single traversal.
It is somewhat embarrassing and amusing at the same time that the
"This is a truly stupid algorithm, but it's only used for bisection,
and we just don't care enough." comment Linus wrote long time ago is
still with us. Many men tried, they did not die but failed.
> I think this is similar to the reachability bitmap computation, which
> computes a bitmap for each commit (and then the weight of each commit is
> the number of set bits, but we've removed the duplicates). We do that in
> a single traversal these days, but it's pretty complex and heavyweight.
The original algorithm was done way before any of the recent
auxiliary data structures were invented. There may be approaches we
haven't tried and can now try to improve bisection, expoliting newer
things like reachability bitmaps.
next prev parent reply other threads:[~2025-01-16 16:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 22:11 [bug] "git bisect old v3.0" takes 21 mins on Linux repo Askar Safin
2025-01-13 23:16 ` Askar Safin
2025-01-14 22:21 ` D. Ben Knoble
2025-01-16 10:52 ` Jeff King
2025-01-16 12:53 ` Jeff King
2025-01-16 13:52 ` Jeff King
2025-01-16 16:40 ` Junio C Hamano [this message]
2025-01-17 5:31 ` Askar Safin
2025-01-17 13:14 ` Jeff King
2025-01-17 16:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo706u2z0.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=safinaskar@zohomail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).