From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Dec 2024, #03; Sun, 8)
Date: Tue, 10 Dec 2024 08:53:15 +0900 [thread overview]
Message-ID: <xmqqo71kmn10.fsf@gitster.g> (raw)
In-Reply-To: <20241209203958.801143-1-jonathantanmy@google.com> (Jonathan Tan's message of "Mon, 9 Dec 2024 12:39:58 -0800")
Jonathan Tan <jonathantanmy@google.com> writes:
> Junio C Hamano <gitster@pobox.com> writes:
>> * jt/fix-fattening-promisor-fetch (2024-12-04) 4 commits
>> - index-pack: work around false positive use of uninitialized variable
>> - index-pack --promisor: also check commits' trees
>> - index-pack --promisor: don't check blobs
>> - index-pack --promisor: dedup before checking links
>>
>> Fix performance regression of a recent "fatten promisor pack with
>> local objects" protection against an unwanted gc.
>>
>> Need to squash the fix-up at the tip.
>> source: <cover.1733262661.git.jonathantanmy@google.com>
>
> I just replied [1] to what I believe is the last outstanding question,
> so I don't think there is any code change needed besides the squashing
> of the fix-up (as you said). If you could squash it locally (onto
> "index-pack --promisor: dedup before checking links") that would be
> great; if not let me know and I'll send an updated version.
Thanks, will (try to remember to) do ;-)
There is nothing in the code that needs to be fixed, but we help
compilers so that they can help us. Let's merge it down to 'next'
after squashing it in.
prev parent reply other threads:[~2024-12-09 23:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-08 9:31 What's cooking in git.git (Dec 2024, #03; Sun, 8) Junio C Hamano
2024-12-09 20:39 ` Jonathan Tan
2024-12-09 23:53 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo71kmn10.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).