* [PATCH] config: fix some small capitalization issues, as spotted
@ 2024-03-30 4:26 Dragan Simic
2024-03-30 20:34 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Dragan Simic @ 2024-03-30 4:26 UTC (permalink / raw)
To: git
Fix some small capitalization issues, as spotted while going through the
documentation. In general, a semicolon doesn't start a new sentence, and
"this" has no meaning of a proper noun in this context.
Signed-off-by: Dragan Simic <dsimic@manjaro.org>
---
Notes:
* Fix some small capitalization issues in the documentation.
Documentation/config/core.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/config/core.txt b/Documentation/config/core.txt
index 2d4bbdb25fa3..31fe417065c6 100644
--- a/Documentation/config/core.txt
+++ b/Documentation/config/core.txt
@@ -688,7 +688,7 @@ core.createObject::
will not overwrite existing objects.
+
On some file system/operating system combinations, this is unreliable.
-Set this config setting to 'rename' there; However, This will remove the
+Set this config setting to 'rename' there; however, this will remove the
check that makes sure that existing object files will not get overwritten.
core.notesRef::
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] config: fix some small capitalization issues, as spotted
2024-03-30 4:26 [PATCH] config: fix some small capitalization issues, as spotted Dragan Simic
@ 2024-03-30 20:34 ` Junio C Hamano
2024-03-31 20:21 ` Dragan Simic
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2024-03-30 20:34 UTC (permalink / raw)
To: Dragan Simic; +Cc: git
Dragan Simic <dsimic@manjaro.org> writes:
> On some file system/operating system combinations, this is unreliable.
> -Set this config setting to 'rename' there; However, This will remove the
> +Set this config setting to 'rename' there; however, this will remove the
> check that makes sure that existing object files will not get overwritten.
Looking good, except that we do not want double-space after a
semicolon.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] config: fix some small capitalization issues, as spotted
2024-03-30 20:34 ` Junio C Hamano
@ 2024-03-31 20:21 ` Dragan Simic
0 siblings, 0 replies; 3+ messages in thread
From: Dragan Simic @ 2024-03-31 20:21 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
Hello Junio,
On 2024-03-30 21:34, Junio C Hamano wrote:
> Dragan Simic <dsimic@manjaro.org> writes:
>
>> On some file system/operating system combinations, this is
>> unreliable.
>> -Set this config setting to 'rename' there; However, This will remove
>> the
>> +Set this config setting to 'rename' there; however, this will remove
>> the
>> check that makes sure that existing object files will not get
>> overwritten.
>
> Looking good, except that we do not want double-space after a
> semicolon.
Thanks, I'll send a v2 that fixes this issue.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-31 20:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-30 4:26 [PATCH] config: fix some small capitalization issues, as spotted Dragan Simic
2024-03-30 20:34 ` Junio C Hamano
2024-03-31 20:21 ` Dragan Simic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox