git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org,
	 "brian m. carlson" <sandals@crustytoothpaste.net>,
	rsbecker@nexbridge.com,
	 Angelo Dureghello <angelo@kernel-space.org>
Subject: Re: [PATCH] t5601: exercise clones with "includeIf.*.onbranch"
Date: Tue, 12 Mar 2024 13:38:26 -0700	[thread overview]
Message-ID: <xmqqo7bjjid9.fsf@gitster.g> (raw)
In-Reply-To: <0bede59a53862585c49bc635f82e44e983144a7f.1710246859.git.ps@pks.im> (Patrick Steinhardt's message of "Tue, 12 Mar 2024 13:35:11 +0100")

Patrick Steinhardt <ps@pks.im> writes:

> +test_expect_success 'clone with includeIf' '
> +	test_when_finished "rm -rf repo \"$HTTPD_DOCUMENT_ROOT_PATH/repo.git\"" &&
> +	git clone --bare --no-local src "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" &&
> +
> +	test_when_finished "rm \"$HOME\"/.gitconfig" &&
> +	cat >"$HOME"/.gitconfig <<-EOF &&
> +	[includeIf "onbranch:something"]
> +		path = /does/not/exist.inc
> +	EOF
> +	git clone $HTTPD_URL/smart/repo.git repo
> +'

Hmph, isn't the end-user expectation more like if you clone with
"git clone -b something" then the configuration stored in the named
file to take effect, while "git clone" that would never place you on
that something branch would ignore that missing file?  Is this only
the latter half of the pair?

Thanks.

  reply	other threads:[~2024-03-12 20:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-08 19:25 [BUG] cannot git clone with includeif onbranch Angelo Dureghello
2024-03-08 20:10 ` brian m. carlson
2024-03-08 20:27   ` Angelo Dureghello
2024-03-08 21:20   ` rsbecker
2024-03-11 23:30   ` Patrick Steinhardt
2024-03-12 12:35 ` [PATCH] t5601: exercise clones with "includeIf.*.onbranch" Patrick Steinhardt
2024-03-12 20:38   ` Junio C Hamano [this message]
2024-03-22  2:01     ` Patrick Steinhardt
2024-03-22  2:11       ` Junio C Hamano
2024-03-22  2:15       ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo7bjjid9.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=angelo@kernel-space.org \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    --cc=rsbecker@nexbridge.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).