From: Junio C Hamano <gitster@pobox.com>
To: Jacob Stopak <jacob@initialcommit.io>,
Emily Shaffer <nasamuffin@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 1/1] bugreport: include +i in outfile suffix as needed
Date: Fri, 20 Oct 2023 17:39:49 -0700 [thread overview]
Message-ID: <xmqqo7gsolka.fsf@gitster.g> (raw)
In-Reply-To: <20231016214045.146862-2-jacob@initialcommit.io> (Jacob Stopak's message of "Mon, 16 Oct 2023 14:40:45 -0700")
Jacob Stopak <jacob@initialcommit.io> writes:
> int cmd_bugreport(int argc, const char **argv, const char *prefix)
> {
> struct strbuf buffer = STRBUF_INIT;
> struct strbuf report_path = STRBUF_INIT;
> int report = -1;
> time_t now = time(NULL);
> - struct tm tm;
> enum diagnose_mode diagnose = DIAGNOSE_NONE;
> char *option_output = NULL;
> - char *option_suffix = "%Y-%m-%d-%H%M";
> + char *option_suffix = "";
> + int option_suffix_is_from_user = 0;
> const char *user_relative_path = NULL;
> char *prefixed_filename;
> - size_t output_path_len;
> int ret;
> + int i = 0;
OK, I think between me and you, we stared at this piece of code long
enough to make ourselves numb. The original "at most one report per
a minute" default came from the very original in 238b439d
(bugreport: add tool to generate debugging info, 2020-04-16) and
that is what we are changing, so let me summon its author as an area
expert for a pair of fresh eyes to see if they can offer any new
insights.
Thanks.
https://lore.kernel.org/git/20231016214045.146862-1-jacob@initialcommit.io/
next prev parent reply other threads:[~2023-10-21 0:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-14 4:01 [PATCH] bugreport: add 'seconds' to default outfile name Jacob Stopak
2023-10-14 10:35 ` Kristoffer Haugsbakk
2023-10-14 16:27 ` Junio C Hamano
2023-10-14 16:33 ` Dragan Simic
2023-10-14 17:45 ` Junio C Hamano
2023-10-14 17:52 ` Dragan Simic
2023-10-15 3:07 ` Jacob Stopak
2023-10-15 3:13 ` Dragan Simic
2023-10-15 3:01 ` Jacob Stopak
2023-10-15 17:06 ` Junio C Hamano
2023-10-15 3:42 ` [PATCH v2 0/3] bugreport: include +i in outfile suffix as needed Jacob Stopak
2023-10-15 3:42 ` [PATCH v2 1/3] " Jacob Stopak
2023-10-15 17:36 ` Junio C Hamano
2023-10-16 21:40 ` [PATCH v3 0/1] " Jacob Stopak
2023-10-16 21:40 ` [PATCH v3 1/1] " Jacob Stopak
2023-10-16 22:55 ` Junio C Hamano
2023-10-17 3:17 ` Jacob Stopak
2023-10-21 0:39 ` Junio C Hamano [this message]
2023-10-26 21:19 ` Emily Shaffer
2023-10-27 6:34 ` Jacob Stopak
2024-01-06 4:54 ` Jacob Stopak
2023-10-15 3:42 ` [PATCH v2 2/3] bugreport: match diagnostics filename with report Jacob Stopak
2023-10-15 3:42 ` [PATCH v2 3/3] bugreport: don't create --diagnose zip w/o report Jacob Stopak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo7gsolka.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob@initialcommit.io \
--cc=nasamuffin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).