git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Josh Soref <jsoref@gmail.com>
Cc: Kristoffer Haugsbakk <code@khaugsbakk.name>,
	Josh Soref via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] pretty-formats.txt: fix whitespace
Date: Tue, 26 Sep 2023 09:42:34 -0700	[thread overview]
Message-ID: <xmqqo7hoophh.fsf@gitster.g> (raw)
In-Reply-To: <CACZqfqCfvWASMPMxRpRuAUQPcprcB4RHxxke_qTZ3bFGLf3T8Q@mail.gmail.com> (Josh Soref's message of "Mon, 25 Sep 2023 22:51:03 -0400")

Josh Soref <jsoref@gmail.com> writes:

> As it (IMO) takes effort (admittedly trivial, and quite likely
> habitual) to insert a second space, I assume that this was a desired
> thing and the one space was the aberration, hence the patch went in
> favor of two spaces.

Back in typewriter days, people were taught to leave two spaces
after a full stop, because on monospace output it was easier to read
that way.  Then the desktop publishing software came and people were
encouraged to leave the appearance up to the software.

So to old timers who have already been trained to type two spaces
after a sentence, it takes more effort not to type the space bar
twice.

But as I said already, I personally feel that the consistency
guidelines around this area should be:

 (1) it would be nice if a new document does not use mixed style, but

 (2) it is not worth the patch noise only to "fix" them one way or
     the other.

Here "patch noise" does not primarily mean the effort a producer of
such a patch spends making sure what they did is correct.  The cost
of making sure unrelated mistakes do not slip into the codebase and
documentation without being noticed is much higher for such a patch
that ought to be a mechanical conversion.

Thanks.

      reply	other threads:[~2023-09-26 16:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-22 14:10 [PATCH] pretty-formats.txt: fix whitespace Josh Soref via GitGitGadget
2023-09-22 21:56 ` Junio C Hamano
2023-09-24 10:31   ` Josh Soref
2023-09-25 17:24     ` Junio C Hamano
2023-09-26 18:52     ` Linus Arver
2023-09-26 19:51       ` Josh Soref
2023-09-26 21:20         ` Linus Arver
2023-09-25 20:04 ` Kristoffer Haugsbakk
2023-09-26  2:51   ` Josh Soref
2023-09-26 16:42     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo7hoophh.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=code@khaugsbakk.name \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=jsoref@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).