git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Phillip Wood <phillip.wood123@gmail.com>,
	"brian m. carlson" <sandals@crustytoothpaste.net>
Subject: Re: [PATCH] CodingGuidelines: give deadline for "for (int i = 0; ..."
Date: Thu, 31 Mar 2022 13:12:09 -0700	[thread overview]
Message-ID: <xmqqo81l286e.fsf@gitster.g> (raw)
In-Reply-To: <220331.86v8vuqv95.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Thu, 31 Mar 2022 12:10:20 +0200")

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

>> A separate weather balloon for C99 as a whole was raised separately
>> in 7bc341e2 (git-compat-util: add a test balloon for C99 support,
>> 2021-12-01).  Hopefully, as we find out that all C99 features are OK
>> on all platforms we care about, we can stop probing the features we
>> want one-by-one like this
>
> Unfortunately this really isn't the case at all, the norm is for
> compilers to advertise that they support verison X of the standard via
> these macros when they consider the support "good enough", but while
> there's still a long list of unimplemented features before they're at
> 100% support (and most never fully get to 100%).
>
> We also need to worry about the stdlib implementation, and not just the
> compiler, see e.g. the %zu format and MinGW in the exchange at
> https://lore.kernel.org/git/220318.86bky3cr8j.gmgdl@evledraar.gmail.com/
> and
> https://lore.kernel.org/git/a67e0fd8-4a14-16c9-9b57-3430440ef93c@gmail.com/;
>
> But I think we're thoroughly past needing to worry about basic language
> features in C99 such as these inline variable declarations.

Well, that makes it sound like the C99 weather balloon was almost
useless, doesn't it?

In any case, I'll strick the last paragraph from the final log
message, as the patch text itself is about one specific feature, and
not about deciding what our policy for various C99 language
feeatures ought to be.

Thanks.

  parent reply	other threads:[~2022-03-31 20:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31  0:09 [PATCH] CodingGuidelines: give deadline for "for (int i = 0; ..." Junio C Hamano
2022-03-31 10:10 ` Ævar Arnfjörð Bjarmason
2022-03-31 14:48   ` Phillip Wood
2022-03-31 14:58     ` Ævar Arnfjörð Bjarmason
2022-03-31 20:12   ` Junio C Hamano [this message]
2022-03-31 21:19     ` brian m. carlson
2022-04-01  9:29       ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo81l286e.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=phillip.wood123@gmail.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).