git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: calvinwan@google.com
Cc: git@vger.kernel.org
Subject: Re: Review process improvements: drafting a ReviewingPatches doc
Date: Fri, 11 Feb 2022 09:28:49 -0800	[thread overview]
Message-ID: <xmqqo83dcnxq.fsf@gitster.g> (raw)
In-Reply-To: <20220210233346.1009735-1-calvinwan@google.com> (calvinwan@google.com's message of "Thu, 10 Feb 2022 23:33:45 +0000")

calvinwan@google.com writes:

> In continuation of Emily’s "Review process improvements"[1], I am
> drafting a ReviewingPatches doc to help standardize the review process
> here on the git mailing list and to provide a rubric/checklist for new
> reviewers. In order to do so, I am looking to compile examples and
> input from everyone by asking the list a set of questions biweekly.
> Please contextualize your answer in terms of whether this was a
> maintainer, individual, or drive-by review.

Often people other than the patch contributors themselves find
others' reviews a useful learning opportunity.  I take it that your
"contextualize" request is asking for comments like "As the
maintainer, I found this review by an area expert very helpful
because ...", as well as "I sent this patch and a drive-by typofix
at this URL was not very helpful"?

When soliciting input from the list, it would probably make it
easier for others if you led by example by sending your answers,
to show the level of detail you'd find useful.

  reply	other threads:[~2022-02-11 17:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 23:33 Review process improvements: drafting a ReviewingPatches doc calvinwan
2022-02-11 17:28 ` Junio C Hamano [this message]
2022-02-11 19:44   ` Calvin Wan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo83dcnxq.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=calvinwan@google.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).