From: Junio C Hamano <gitster@pobox.com>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: git@vger.kernel.org, avarab@gmail.com,
"Randall S . Becker" <rsbecker@nexbridge.com>
Subject: Re: [PATCH] wrapper: remove xunsetenv()
Date: Fri, 29 Oct 2021 14:53:30 -0700 [thread overview]
Message-ID: <xmqqo877ijl1.fsf@gitster.g> (raw)
In-Reply-To: <20211029212705.31721-1-carenas@gmail.com> ("Carlo Marcelo Arenas Belón"'s message of "Fri, 29 Oct 2021 14:27:05 -0700")
Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:
> Platforms that are using the git compatibility layer for unsetenv
> use void as a return value for unsetenv(), so any function that checks
> for a return value will fail to build.
It sounds like barking up a wrong tree. unsetenv() is supposed to
signal success with 0 and failure with -1, and the compat/
implementation is broken, not the caller that tries to be nice and
check the error return from the system function it calls.
Not that adding the unused wrapper, and leaving it unused, was a
wise decision in hindsight, though.
prev parent reply other threads:[~2021-10-29 21:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <013a01d7cd092d91cb088b5610nexbridge.com>
2021-10-29 21:27 ` [PATCH] wrapper: remove xunsetenv() Carlo Marcelo Arenas Belón
2021-10-29 21:37 ` Jeff King
2021-10-29 21:43 ` rsbecker
2021-10-29 21:50 ` Carlo Arenas
2021-10-29 21:56 ` Junio C Hamano
2021-10-29 21:51 ` Jeff King
2021-10-29 21:58 ` Junio C Hamano
2021-10-29 22:00 ` Jeff King
2021-10-29 22:03 ` Junio C Hamano
2021-10-29 23:11 ` Jeff King
2021-10-29 22:01 ` rsbecker
2021-10-29 22:29 ` Junio C Hamano
2021-10-30 0:13 ` rsbecker
2021-10-29 21:37 ` rsbecker
2021-10-29 21:43 ` Carlo Arenas
2021-10-29 21:48 ` rsbecker
2021-10-29 21:53 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo877ijl1.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).