From: Junio C Hamano <gitster@pobox.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Derrick Stolee <stolee@gmail.com>,
git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH] multi-pack-index: fix --object-dir from outside repo
Date: Mon, 23 Aug 2021 01:05:40 -0700 [thread overview]
Message-ID: <xmqqo89osi0b.fsf@gitster.g> (raw)
In-Reply-To: <4d65ef5b0a9e4104d763facc42d10a20557d054d.camel@sipsolutions.net> (Johannes Berg's message of "Mon, 23 Aug 2021 09:21:10 +0200")
Johannes Berg <johannes@sipsolutions.net> writes:
> I just needed to go outside the current test git directory, the tests
> are running in a way that the current working directory is already the
> git tree I'm operating in.
>
>> Even if you mean to use "cd",
>> please do so within a sub-shell.
>
> I thought about it, but clearly all the tests are run in a sub-shell, so
> it didn't seem necessary? But happy to change, I don't really care
> either way.
Please learn to care before you write your next test, then ;-)
These tests are not run in a sub-shell; they are eval'ed, so that
the assignment they make to variables can persist and affect the
next test piece.
Thanks.
next prev parent reply other threads:[~2021-08-23 8:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 19:35 [PATCH] multi-pack-index: fix --object-dir from outside repo Johannes Berg
2021-08-22 23:51 ` Derrick Stolee
2021-08-23 7:21 ` Johannes Berg
2021-08-23 8:05 ` Junio C Hamano [this message]
2021-08-23 8:10 ` Johannes Berg
2021-08-23 13:19 ` Derrick Stolee
2021-08-23 13:40 ` Johannes Berg
2021-08-23 16:16 ` Junio C Hamano
2021-08-23 16:06 ` Junio C Hamano
2021-08-23 0:54 ` Taylor Blau
2021-08-23 7:32 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo89osi0b.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johannes@sipsolutions.net \
--cc=me@ttaylorr.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).