From: Junio C Hamano <gitster@pobox.com>
To: Tassilo Horn <tsdh@gnu.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v5] userdiff: improve java hunk header regex
Date: Wed, 11 Aug 2021 11:11:08 -0700 [thread overview]
Message-ID: <xmqqo8a397ib.fsf@gitster.g> (raw)
In-Reply-To: <87im0b6f92.fsf@gnu.org> (Tassilo Horn's message of "Wed, 11 Aug 2021 19:42:59 +0200")
Tassilo Horn <tsdh@gnu.org> writes:
> That leads to the question if you'd welcome a patch adding a
> .dir-locals.el to the repository with the right settings so that it'll
> just work for contributors using the One True Editor. Would you?
If your one true editor honored what is in .editorconfig, perhaps
there was no need for us to be having this conversation? I dunno.
Our .gitattributes (the top one and also in subdirectories) try to
give reasonable whitespace rules for files, and specifically, files
in t/t????/ directories that are used as test vectors completely
disable whitespace checking, while everywhere else we insist certain
styles in the top-level .gitattributes file.
Thanks.
next prev parent reply other threads:[~2021-08-11 18:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 14:53 [PATCH v5] userdiff: improve java hunk header regex Tassilo Horn
2021-08-11 17:16 ` Junio C Hamano
2021-08-11 17:42 ` Tassilo Horn
2021-08-11 18:11 ` Junio C Hamano [this message]
2021-08-11 18:55 ` Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo8a397ib.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).