From: Junio C Hamano <gitster@pobox.com>
To: "Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Han-Wen Nienhuys <hanwenn@gmail.com>,
Han-Wen Nienhuys <hanwen@google.com>
Subject: Re: [PATCH v2 08/11] t1410: mark test as REFFILES
Date: Fri, 23 Jul 2021 10:32:01 -0700 [thread overview]
Message-ID: <xmqqo8atndgu.fsf@gitster.g> (raw)
In-Reply-To: <f931a26de58e3cc7bb6522fab47e934aca7dc776.1626989327.git.gitgitgadget@gmail.com> (Han-Wen Nienhuys via GitGitGadget's message of "Thu, 22 Jul 2021 21:28:44 +0000")
"Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Han-Wen Nienhuys <hanwen@google.com>
>
> In reftable, one cannot take a lock on an individual ref.
>
> Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
> ---
> t/t1410-reflog.sh | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Makes sense, I guess, but it makes it sound as if you can only take
a big single lock to freeze everything (as opposed to being able to
work on independent refs in parallel). Is that what you meant to
say?
A file somewhere in .git/refs/ directory shouldn't be a way to lock
a ref in the reftable world, either, so it doubly makes sense.
> diff --git a/t/t1410-reflog.sh b/t/t1410-reflog.sh
> index 27b9080251a..d42f067ff8c 100755
> --- a/t/t1410-reflog.sh
> +++ b/t/t1410-reflog.sh
> @@ -374,7 +374,9 @@ test_expect_failure 'reflog with non-commit entries displays all entries' '
> test_line_count = 3 actual
> '
>
> -test_expect_success 'reflog expire operates on symref not referrent' '
> +# This test takes a lock on an individual ref; this is not supported in
> +# reftable.
> +test_expect_success REFFILES 'reflog expire operates on symref not referrent' '
> git branch --create-reflog the_symref &&
> git branch --create-reflog referrent &&
> git update-ref referrent HEAD &&
next prev parent reply other threads:[~2021-07-23 17:32 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 18:07 [PATCH 0/6] Fix direct filesystem access in various test files Han-Wen Nienhuys via GitGitGadget
2021-07-19 18:07 ` [PATCH 1/6] t6050: use git-update-ref rather than filesystem access Han-Wen Nienhuys via GitGitGadget
2021-07-19 18:07 ` [PATCH 2/6] t1503: mark symlink test as REFFILES Han-Wen Nienhuys via GitGitGadget
2021-07-19 18:07 ` [PATCH 3/6] t6120: use git-update-ref rather than filesystem access Han-Wen Nienhuys via GitGitGadget
2021-07-19 18:07 ` [PATCH 4/6] t7509: " Han-Wen Nienhuys via GitGitGadget
2021-07-19 21:35 ` Junio C Hamano
2021-07-19 18:07 ` [PATCH 5/6] t3320: use git-symbolic-ref " Han-Wen Nienhuys via GitGitGadget
2021-07-19 18:07 ` [PATCH 6/6] t2402: use ref-store test helper to create broken symlink Han-Wen Nienhuys via GitGitGadget
2021-07-22 21:28 ` [PATCH v2 00/11] Fix direct filesystem access in various test files Han-Wen Nienhuys via GitGitGadget
2021-07-22 21:28 ` [PATCH v2 01/11] t6050: use git-update-ref rather than filesystem access Han-Wen Nienhuys via GitGitGadget
2021-07-22 21:28 ` [PATCH v2 02/11] t1503: mark symlink test as REFFILES Han-Wen Nienhuys via GitGitGadget
2021-07-22 21:28 ` [PATCH v2 03/11] t6120: use git-update-ref rather than filesystem access Han-Wen Nienhuys via GitGitGadget
2021-07-22 21:28 ` [PATCH v2 04/11] t3320: use git-symbolic-ref " Han-Wen Nienhuys via GitGitGadget
2021-07-22 21:28 ` [PATCH v2 05/11] t2402: use ref-store test helper to create broken symlink Han-Wen Nienhuys via GitGitGadget
2021-07-22 21:28 ` [PATCH v2 06/11] t1405: use 'git reflog exists' to check reflog existence Han-Wen Nienhuys via GitGitGadget
2021-07-23 17:15 ` Junio C Hamano
2021-07-22 21:28 ` [PATCH v2 07/11] t1405: mark test for 'git pack-refs' as REFFILES Han-Wen Nienhuys via GitGitGadget
2021-07-23 17:28 ` Junio C Hamano
2021-07-22 21:28 ` [PATCH v2 08/11] t1410: mark test " Han-Wen Nienhuys via GitGitGadget
2021-07-23 17:32 ` Junio C Hamano [this message]
2021-07-22 21:28 ` [PATCH v2 09/11] t7064: use update-ref -d to remove upstream branch Han-Wen Nienhuys via GitGitGadget
2021-07-23 17:37 ` Junio C Hamano
2021-07-22 21:28 ` [PATCH v2 10/11] t6500: use "ls -1" to snapshot ref database state Han-Wen Nienhuys via GitGitGadget
2021-07-22 21:28 ` [PATCH v2 11/11] t6001: avoid direct file system access Han-Wen Nienhuys via GitGitGadget
2021-07-23 17:40 ` Junio C Hamano
2021-07-23 17:44 ` [PATCH v2 00/11] Fix direct filesystem access in various test files Junio C Hamano
2021-08-02 13:38 ` Han-Wen Nienhuys
2021-08-02 16:27 ` Junio C Hamano
2021-08-02 16:28 ` Junio C Hamano
2021-08-02 16:53 ` Han-Wen Nienhuys
2021-08-02 16:53 ` [PATCH v3 " Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53 ` [PATCH v3 01/11] t6050: use git-update-ref rather than filesystem access Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53 ` [PATCH v3 02/11] t1503: mark symlink test as REFFILES Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53 ` [PATCH v3 03/11] t6120: use git-update-ref rather than filesystem access Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53 ` [PATCH v3 04/11] t3320: use git-symbolic-ref " Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53 ` [PATCH v3 05/11] t2402: use ref-store test helper to create broken symlink Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53 ` [PATCH v3 06/11] t1405: use 'git reflog exists' to check reflog existence Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53 ` [PATCH v3 07/11] t1405: mark test for 'git pack-refs' as REFFILES Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53 ` [PATCH v3 08/11] t1410: mark test " Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53 ` [PATCH v3 09/11] t7064: use update-ref -d to remove upstream branch Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53 ` [PATCH v3 10/11] t6500: use "ls -1" to snapshot ref database state Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53 ` [PATCH v3 11/11] t6001: avoid direct file system access Han-Wen Nienhuys via GitGitGadget
2021-08-02 20:07 ` [PATCH v3 00/11] Fix direct filesystem access in various test files Junio C Hamano
2021-08-02 21:32 ` Junio C Hamano
2021-08-03 9:37 ` Han-Wen Nienhuys
2021-07-22 22:24 ` [PATCH 0/6] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo8atndgu.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=hanwen@google.com \
--cc=hanwenn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).