git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Pete Boere <pete@duel.me>
Cc: git@vger.kernel.org, John Lin <johnlinp@gmail.com>
Subject: Re: Extra blank lines in "git status" output have been reduced
Date: Wed, 17 Mar 2021 12:38:42 -0700	[thread overview]
Message-ID: <xmqqo8fhtvst.fsf@gitster.g> (raw)
In-Reply-To: <CAF8W_bFzE8strSWc0_eABdyfCxA+0CA6ph_uXgSyT7YRU-jO6A@mail.gmail.com> (Pete Boere's message of "Wed, 17 Mar 2021 10:22:50 +0000")

Pete Boere <pete@duel.me> writes:

> With the release of v2.23 I have noticed from the commit:
> 7b098429355bb3271f9ffdf73b97f2ef82794fea
> ...
> Is there any chance of adding them back? The changed layout has been
> throwing me off ever since upgrading.

Sorry, but it is way too late to complain, generally after a change
hits a release, and especially after it got buried under 8 new major
releases.  Unless a change was an unintended side-effect that we did
not mean to make, in which case we would likely to fix it as a bug.

And the change in question b2f5171e (status: remove the empty line
after hints, 2019-06-04) quite deliberately targets at removing
these extra lines [*], so no, I do not think it is reasonable to
expect reverting that commit that is more than a year old.

You may want to join the list discussion and stop whatever UI change
you find undesirable before it materializes next time.


[Reference]

commit b2f5171ecc2feb4192acd80f5a6b05c06e099e97
Author: John Lin <johnlinp@gmail.com>
Date:   Tue Jun 4 07:02:21 2019 -0700

    status: remove the empty line after hints
    
    Before this patch, there is inconsistency between the status
    messages with hints and the ones without hints: there is an
    empty line between the title and the file list if hints are
    presented, but there isn't one if there are no hints.
    
    This patch remove the inconsistency by removing the empty
    lines even if hints are presented.

  reply	other threads:[~2021-03-17 19:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17 10:22 Extra blank lines in "git status" output have been reduced Pete Boere
2021-03-17 19:38 ` Junio C Hamano [this message]
2021-03-17 20:18   ` Jeff King
2021-03-17 21:28     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo8fhtvst.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=johnlinp@gmail.com \
    --cc=pete@duel.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).