From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Jeff King <peff@peff.net>,
Eric Sunshine <sunshine@sunshineco.com>,
Git List <git@vger.kernel.org>
Subject: Re: Is t5516 somehow flakey only on macOS?
Date: Sat, 09 Jan 2021 14:42:56 -0800 [thread overview]
Message-ID: <xmqqo8hxenpr.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20210109173336.GS8396@szeder.dev> ("SZEDER Gábor"'s message of "Sat, 9 Jan 2021 18:33:36 +0100")
SZEDER Gábor <szeder.dev@gmail.com> writes:
>> Commit 014ade7484 (upload-pack: send ERR packet for non-tip objects,
>> 2019-04-13) added a test that greps the output of a failed fetch to make
>> sure that upload-pack sent us the ERR packet we expected. But checking
>> this is racy; despite the argument in that commit, the client may still
>> be sending a "done" line when the server exits, causing it to die() on a
>
> Nit: I think using the word "after" would make the problematic
> sequence of events a tad clearer, i.e. "... after the server has
> exited, ...".
Thanks everybody for helping with extra clarity. I do find it
easier to follow with "after the server has exited" to picture
the sequence of events in my mind.
next prev parent reply other threads:[~2021-01-09 22:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 0:37 Is t5516 somehow flakey only on macOS? Junio C Hamano
2021-01-09 9:11 ` Eric Sunshine
2021-01-09 10:34 ` Jeff King
2021-01-09 10:48 ` Jeff King
2021-01-09 10:57 ` Eric Sunshine
2021-01-09 17:33 ` SZEDER Gábor
2021-01-09 22:42 ` Junio C Hamano [this message]
2021-01-10 3:23 ` Jeff King
2021-01-09 22:29 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo8hxenpr.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).