git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: git@vger.kernel.org, Emily Shaffer <emilyshaffer@google.com>
Subject: Re: [PATCH] progress: don't dereference before checking for NULL
Date: Mon, 10 Aug 2020 14:57:57 -0700	[thread overview]
Message-ID: <xmqqo8nib1ui.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200810194748.1483784-1-martin.agren@gmail.com> ("Martin Ågren"'s message of "Mon, 10 Aug 2020 21:47:48 +0200")

Martin Ågren <martin.agren@gmail.com> writes:

> The progress API handles NULL just fine, but
> that's the NULL-ness of `*p_progress`, e.g., when running with
> `--no-progress`. If `p_progress` is NULL, chances are that's a mistake.

True, true.

Thanks.

      parent reply	other threads:[~2020-08-10 21:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-10 19:47 [PATCH] progress: don't dereference before checking for NULL Martin Ågren
2020-08-10 21:26 ` Eric Sunshine
2020-08-11  4:28   ` Martin Ågren
2020-08-11 15:41     ` Taylor Blau
2020-08-10 21:57 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo8nib1ui.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=martin.agren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).