From: Junio C Hamano <gitster@pobox.com>
To: randall.s.becker@rogers.com
Cc: git@vger.kernel.org, "Randall S. Becker" <randall.becker@nexbridge.ca>
Subject: Re: [Patch v2 0/2] Replace strbuf_write_fd with write_in_full
Date: Fri, 19 Jun 2020 13:51:39 -0700 [thread overview]
Message-ID: <xmqqo8peg4o4.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200619202320.4619-1-randall.s.becker@rogers.com> (randall s. becker's message of "Fri, 19 Jun 2020 16:23:18 -0400")
randall.s.becker@rogers.com writes:
> From: "Randall S. Becker" <randall.becker@nexbridge.ca>
>
> The strbuf_write_fd method does not check whether the buffer exceeds
> MAX_IO_SIZE on the target platform. This fix replaces the use of that
> method with write_in_full, which does. Since this is the only use of
> strbuf_write_fd, and since the method was unsafe, it has been removed
> from strbuf.c and strbuf.h.
Excellent. Thanks.
Will queue.
prev parent reply other threads:[~2020-06-19 20:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200619202320.4619-1-randall.s.becker.ref@rogers.com>
2020-06-19 20:23 ` [Patch v2 0/2] Replace strbuf_write_fd with write_in_full randall.s.becker
2020-06-19 20:23 ` [Patch v2 1/2] bugreport.c: replace " randall.s.becker
2020-06-19 20:23 ` [Patch v2 2/2] strbuf: remove unreferenced strbuf_write_fd method randall.s.becker
2020-06-19 20:51 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo8peg4o4.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=randall.becker@nexbridge.ca \
--cc=randall.s.becker@rogers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).