From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2275C433E0 for ; Fri, 19 Jun 2020 20:51:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 91C7721532 for ; Fri, 19 Jun 2020 20:51:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="oKml2GYT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391227AbgFSUvq (ORCPT ); Fri, 19 Jun 2020 16:51:46 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:64967 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391103AbgFSUvp (ORCPT ); Fri, 19 Jun 2020 16:51:45 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 71A7ECB94D; Fri, 19 Jun 2020 16:51:43 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=eNISAVhPNR5d4aND1LIwiVOs4yg=; b=oKml2G YTf6xy0+Q8CYq7xdLorvA6dWzTNHIorc0BPNbjtwwlG5g6+6M01g1OeYzyKFZtVH 4zPr4L/vU5taEJt6khaII0Vyz8F5OBOv1D8rtqB1VDWWtP+mlII7P3s0c7z/hFUh Jr4PV258vZSRjoUrj0Ps3Warnl8bEn7BDENDc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=n/aHUMS4zohRdLHCBV8NyFtqjXnF+MJd ozwnh6mKgbRaU//R7RFPsQqpYiATXREKnSIHrwc/++Qp60W8INYKMXNpQgEqEOhB /6LZphdd4G1ZIChXD6lj9aSjny5xbd50MaI6/gtVhqOWWsslZPjLsHVbb7ajF71T Fn+XN1wFbnk= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 6ABA7CB94C; Fri, 19 Jun 2020 16:51:43 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.196.173.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id B3BBBCB947; Fri, 19 Jun 2020 16:51:40 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: randall.s.becker@rogers.com Cc: git@vger.kernel.org, "Randall S. Becker" Subject: Re: [Patch v2 0/2] Replace strbuf_write_fd with write_in_full References: <20200619202320.4619-1-randall.s.becker.ref@rogers.com> <20200619202320.4619-1-randall.s.becker@rogers.com> Date: Fri, 19 Jun 2020 13:51:39 -0700 In-Reply-To: <20200619202320.4619-1-randall.s.becker@rogers.com> (randall s. becker's message of "Fri, 19 Jun 2020 16:23:18 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: AD0AF158-B26E-11EA-9F5B-B0405B776F7B-77302942!pb-smtp20.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org randall.s.becker@rogers.com writes: > From: "Randall S. Becker" > > The strbuf_write_fd method does not check whether the buffer exceeds > MAX_IO_SIZE on the target platform. This fix replaces the use of that > method with write_in_full, which does. Since this is the only use of > strbuf_write_fd, and since the method was unsafe, it has been removed > from strbuf.c and strbuf.h. Excellent. Thanks. Will queue.