From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: Derrick Stolee <stolee@gmail.com>,
Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Shaun Case <warmsocks@gmail.com>
Subject: Re: [PATCH] sparse-checkout: avoid staging deletions of all files
Date: Thu, 04 Jun 2020 10:21:08 -0700 [thread overview]
Message-ID: <xmqqo8pypx17.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <xmqqsgfapx5i.fsf@gitster.c.googlers.com> (Junio C. Hamano's message of "Thu, 04 Jun 2020 10:18:33 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> list_files() {
> # Do not replace this with 'ls "$1"', as "ls" with BSD-lineage
> # enables "-A" by default for root and ends up including ".git" and
> # such in its output. (Note, though, that running the test suite as
> # root is generally not recommended.)
> (cd "$1" && printf '%s\n' *)
> }
An unrelated tangent, but it took me more time than necessary to
find where these "macros" are defined because
git grep 'check_files () {'
found no matches. That is why I prefer to stress about styles (no,
looking for "check_files *()" is not a solution).
next prev parent reply other threads:[~2020-06-04 17:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 8:17 [PATCH] sparse-checkout: avoid staging deletions of all files Elijah Newren via GitGitGadget
2020-06-04 14:48 ` Derrick Stolee
2020-06-04 15:05 ` Elijah Newren
2020-06-04 15:23 ` Derrick Stolee
2020-06-04 17:08 ` Junio C Hamano
2020-06-04 17:18 ` Junio C Hamano
2020-06-04 17:21 ` Junio C Hamano [this message]
2020-06-04 16:57 ` Junio C Hamano
2020-06-05 2:41 ` [PATCH v2] " Elijah Newren via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo8pypx17.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=newren@gmail.com \
--cc=stolee@gmail.com \
--cc=warmsocks@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).