From: Junio C Hamano <gitster@pobox.com>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] CI: enable t1509 in Travis and GitHub Actions
Date: Wed, 13 May 2020 16:59:42 -0700 [thread overview]
Message-ID: <xmqqo8qrqtch.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200513235215.GA10618@danh.dev> ("Đoàn Trần Công Danh"'s message of "Thu, 14 May 2020 06:52:15 +0700")
Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:
>> >
>> > +chmod a+w /
>> > +
>> > # Build and test
>> > command $switch_cmd su -m -l $CI_USER -c "
>> > set -ex
>> > @@ -68,6 +70,7 @@ command $switch_cmd su -m -l $CI_USER -c "
>> > export GIT_TEST_CLONE_2GB='$GIT_TEST_CLONE_2GB'
>> > export MAKEFLAGS='$MAKEFLAGS'
>> > export cache_dir='$cache_dir'
>> > + export IKNOWWHATIAMDOING=YES
>> > cd /usr/src/git
>> > test -n '$cache_dir' && ln -s '$cache_dir/.prove' t/.prove
>> > make
>>
>> Big EWWWWWWwwww. Do we need to do this for _all_ tests, not
>> selectively only while running t1509? This makes me worried as a
>> test by mistake can easily corrupt the VM and invalidating the
>> tests; I know we get a fresh one every time, so there is no
>> permanent harm done by corrupting it, but having one fewer thing we
>> have to worry about is always better than having one more thing.
>
> Perhaps pass this variable all the way down from ci/lib.sh?
> Adding another variable into t1509 (except T1509_*) doesn't make it
> less risky.
> Or should we add T1509_ prefix to this env var?
I was not worried about any environment variable, but the "let's
make the root directory writable by anybody during _all_ tests",
when we need such a crazy permission bits on the filesystem only
while running t1509 and not any other time, stood out as extremely
yucky.
next prev parent reply other threads:[~2020-05-13 23:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 13:23 [PATCH 0/2] CI: Enable t1509 on GitHub Actions and Travis Đoàn Trần Công Danh
2020-05-13 13:23 ` [PATCH 1/2] t1509: correct i18n test Đoàn Trần Công Danh
2020-05-13 16:43 ` Junio C Hamano
2020-05-13 13:23 ` [PATCH 2/2] CI: enable t1509 in Travis and GitHub Actions Đoàn Trần Công Danh
2020-05-13 16:51 ` Junio C Hamano
2020-05-13 23:52 ` Đoàn Trần Công Danh
2020-05-13 23:59 ` Junio C Hamano [this message]
2020-05-13 16:41 ` [PATCH 0/2] CI: Enable t1509 on GitHub Actions and Travis Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo8qrqtch.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).