git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Jean-Noël Avila" <jn.avila@free.fr>
Cc: Jiang Xin <worldhello.net@gmail.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH] Fix typos in translatable strings for v2.21.0
Date: Mon, 11 Feb 2019 12:57:29 -0800	[thread overview]
Message-ID: <xmqqo97igi12.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <1517c545-0028-56e4-fc58-fb3c6d3551fe@free.fr> ("Jean-Noël Avila"'s message of "Mon, 11 Feb 2019 09:50:02 +0100")

Jean-Noël Avila <jn.avila@free.fr> writes:

> On 11 février 2019, Jiang Xin wrote:
>
>> Jean-Noël Avila <jn.avila@free.fr> 于2019年2月11日周一 下午2:48写道：
>>> Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
>>> ---
>>>  builtin/bisect--helper.c | 4 ++--
>>>  builtin/fetch.c          | 2 +-
>>>  builtin/rebase.c         | 2 +-
>>>  3 files changed, 4 insertions(+), 4 deletions(-)
>> This re-roll is v2 (forgot suffix v2 in subject), and LGTM.
>> Difference between v1 and v2:
>>
>>      -              die(_("--reschedule-failed-exec requires an
>> interactive rebase"));
>>     -+              die(_("%s requires an interactive rebase",
>> "--reschedule-failed-exec"));
>>     ++              die(_("%s requires an interactive rebase"),
>> "--reschedule-failed-exec");
> Thanks for reviewing. The first submission was too hasty and did not
> even compile.

Thanks, both.  Will queue.

      reply	other threads:[~2019-02-11 20:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-09 21:30 [PATCH] Fix typos in translatable strings for v2.21.0 Jean-Noël Avila
2019-02-09 21:33 ` Jean-Noël AVILA
2019-02-11  6:44 ` Jean-Noël Avila
2019-02-11  8:09   ` Jiang Xin
2019-02-11  8:50     ` Jean-Noël Avila
2019-02-11 20:57       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo97igi12.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jn.avila@free.fr \
    --cc=worldhello.net@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).