From: Junio C Hamano <gitster@pobox.com>
To: istephens@atlassian.com
Cc: git@vger.kernel.org, szeder.dev@gmail.com, peff@peff.net,
bturner@atlassian.com, jacob.keller@gmail.com,
sunshine@sunshineco.com
Subject: Re: [PATCH v6 2/2] log: prevent error if line range ends past end of file
Date: Fri, 01 Jun 2018 10:23:06 +0900 [thread overview]
Message-ID: <xmqqo9gvb8qt.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180531050030.43364-2-istephens@atlassian.com> (istephens@atlassian.com's message of "Thu, 31 May 2018 15:00:30 +1000")
istephens@atlassian.com writes:
> From: Isabella Stephens <istephens@atlassian.com>
>
> If the -L option is used to specify a line range in git log, and the end
> of the range is past the end of the file, git will fail with a fatal
> error. This commit prevents such behaviour - instead we perform the log
> for existing lines within the specified range.
>
> This commit also fixes a corner case where -L ,-n:file would be treated
> as a log over the whole file. Now we treat this as -L 1,-n:file and
> blame the first line of the file instead.
>
> Signed-off-by: Isabella Stephens <istephens@atlassian.com>
> ---
> line-log.c | 8 +++++---
> t/t4211-line-log.sh | 5 ++---
> 2 files changed, 7 insertions(+), 6 deletions(-)
Thanks. Will queue.
next prev parent reply other threads:[~2018-06-01 1:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 5:00 [PATCH v6 1/2] blame: prevent error if range ends past end of file istephens
2018-05-31 5:00 ` [PATCH v6 2/2] log: prevent error if line " istephens
2018-06-01 1:23 ` Junio C Hamano [this message]
2018-06-01 1:27 ` [PATCH v6 1/2] blame: prevent error if " Junio C Hamano
2018-06-15 6:29 ` [PATCH v7 " istephens
2018-06-15 6:29 ` [PATCH v7 2/2] log: prevent error if line " istephens
2018-06-15 6:36 ` [PATCH v6 1/2] blame: prevent error if " Isabella Stephens
2018-06-15 18:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo9gvb8qt.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=bturner@atlassian.com \
--cc=git@vger.kernel.org \
--cc=istephens@atlassian.com \
--cc=jacob.keller@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).