Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ivan Ukhov <ivan.ukhov@gmail.com>
Cc: Paul Tan <pyokagan@gmail.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH] parse-options: fix the description of defval
Date: Sun, 29 Mar 2015 11:18:47 -0700	[thread overview]
Message-ID: <xmqqoanby8e0.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <BE8DB6BF-DB95-4D9B-A01B-3D3BCE4C3C9C@gmail.com> (Ivan Ukhov's message of "Sun, 29 Mar 2015 20:02:06 +0200")

Ivan Ukhov <ivan.ukhov@gmail.com> writes:

> Hello Junio,
>
>
> Yes, actually my intention to fix that comment was solely based on its
> content. I saw that the elements in the first set, {BIT,SET_INT}, did
> not match the elements in the second, {mask,integer,pointer}. Then I
> found that commit removing OPT_SET_PTR, and “pointer” seemed to be a
> leftover, which I decided to eliminate. My commit message was saying
> something different, I should admit)
>
> I totally agree with your about mentioning only the general principle
> and leaving details to particular macros.
>
>
> Regards,
> Ivan

OK, lest we forget, please send an updated patch marked as v2 with
proposed commit log message that does not say something different,
then ;-)

Thanks.

      reply	other threads:[~2015-03-29 18:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-29  8:32 [PATCH] parse-options: fix the description of defval Ivan Ukhov
2015-03-29  9:08 ` Paul Tan
2015-03-29  9:28   ` Ivan Ukhov
2015-03-29 13:27     ` Paul Tan
2015-03-29 13:45       ` Ivan Ukhov
2015-03-29 17:39   ` Junio C Hamano
2015-03-29 18:02     ` Ivan Ukhov
2015-03-29 18:18       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqoanby8e0.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ivan.ukhov@gmail.com \
    --cc=pyokagan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox