From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>,
git@vger.kernel.org, Kristofer Karlsson <krka@spotify.com>
Subject: Re: [PATCH v2 0/2] builtin/repo: improve counting of objects
Date: Mon, 16 Nov 2026 09:32:00 -0800 [thread overview]
Message-ID: <xmqqpkw4lm27.fsf@gitster.g> (raw)
In-Reply-To: <aacc4357-7f8c-4e5f-8cb2-1d2bdec767e4@gmail.com> (Derrick Stolee's message of "Mon, 16 Nov 2026 11:02:30 -0500")
Derrick Stolee <stolee@gmail.com> writes:
> On 11/16/2026 3:01 AM, Patrick Steinhardt wrote:
>> I was recently using `git repo structure` in a very large repository and
>> was eventually greeted with an OOM. So I had a bit of a look and found a
>> way to improve the memory footprint and speed it up a bit.
>>
>> The repository still doesn't produce results. As it turns out, walking
>> 33 billion tree entries takes a while, and everything rev-list based
>> that walks trees is kinda broken in there. Oh, well, a problem for
>> another day.
>>
>> Changes in v2:
>> - Reword a comment to point out that parsing the commit should in
>> theory not be required.
>> - Link to v1: https://patch.msgid.link/20261113-pks-repo-count-objects-speedup-
> Thanks for these changes. I found your v2 patches in my inbox somehow
> disconnected from this cover letter. But I'm happy with v2.
Thanks for writing and reviewing. Let me mark the topic as ready
for 'next'.
prev parent reply other threads:[~2026-11-16 17:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 11:46 [PATCH 0/2] builtin/repo: improve counting of objects Patrick Steinhardt
2026-11-13 11:46 ` [PATCH 1/2] builtin/repo: only parse objects as needed Patrick Steinhardt
2026-11-13 14:12 ` Kristofer Karlsson
2026-11-16 6:38 ` Patrick Steinhardt
2026-11-16 9:02 ` Kristofer Karlsson
2026-11-13 11:46 ` [PATCH 2/2] builtin/repo: don't fully parse trees Patrick Steinhardt
2026-11-13 14:15 ` Kristofer Karlsson
2026-11-16 6:39 ` Patrick Steinhardt
2026-11-16 13:43 ` Derrick Stolee
2026-11-16 8:01 ` [PATCH v2 0/2] builtin/repo: improve counting of objects Patrick Steinhardt
2026-11-16 8:01 ` [PATCH v2 1/2] builtin/repo: only parse objects as needed Patrick Steinhardt
2026-11-16 8:01 ` [PATCH v2 2/2] builtin/repo: don't fully parse trees Patrick Steinhardt
2026-11-16 9:07 ` [PATCH v2 0/2] builtin/repo: improve counting of objects Kristofer Karlsson
2026-11-16 16:02 ` Derrick Stolee
2026-11-16 17:32 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpkw4lm27.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=krka@spotify.com \
--cc=ps@pks.im \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox