From: Junio C Hamano <gitster@pobox.com>
To: "Matt Hunter" <m@lfurio.us>
Cc: "Colin Hinton" <colinlewishinton@gmail.com>, <git@vger.kernel.org>
Subject: Re: [PATCH v2] fetch.c: defer fetch.followRemoteHEAD validation
Date: Wed, 30 Sep 2026 11:46:17 -0700 [thread overview]
Message-ID: <xmqqpkxua87a.fsf@gitster.g> (raw)
In-Reply-To: <DLSD3JY380Q4.2VPO95D7M213G@lfurio.us> (Matt Hunter's message of "Wed, 30 Sep 2026 00:21:48 -0400")
"Matt Hunter" <m@lfurio.us> writes:
> I agree with this assessment. However, I wonder if Junio meant
>
> We should (do something similar) to (what remote.c parses) ...
>
> instead of
>
> We should do (something similar to what remote.c parses) ...
>
> as the issue in the NEEDSWORK _does_ apply to both sides.
Exactly.
> Perhaps at a minimum, this patch should leave the comment intact (or
> reworded) if not yet addressing remote.c. v3 otherwise is looking good
> to me, and functionality seems to work.
To end users, the annoyance factor due to an irrelevant incorrect
setting in fetch.followRemoteHEAD and remote.*.followRemoteHEAD
variables killing their "git fetch" are the same. Correcting one
may be better than correcting none, but until both gets corrected,
we cannot claim we helped users.
Thanks.
next prev parent reply other threads:[~2026-09-30 18:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 4:00 [PATCH] fetch.c: defer fetch.followRemoteHEAD validation Colin Hinton
2026-09-22 5:32 ` Junio C Hamano
2026-09-23 5:03 ` Colin Hinton
2026-09-24 7:50 ` Matt Hunter
2026-09-25 18:48 ` Colin Hinton
2026-09-24 7:50 ` Matt Hunter
2026-09-25 19:26 ` [PATCH v2] " Colin Hinton
2026-09-25 19:40 ` Junio C Hamano
2026-09-25 20:30 ` Colin Hinton
2026-09-30 4:21 ` Matt Hunter
2026-09-30 18:46 ` Junio C Hamano [this message]
2026-10-03 4:50 ` Colin Hinton
2026-09-25 23:06 ` [PATCH v3] " Colin Hinton
2026-10-03 23:14 ` [PATCH v4] " Colin Hinton
2026-10-04 13:27 ` Junio C Hamano
2026-10-04 15:40 ` Colin Hinton
2026-10-04 17:42 ` Junio C Hamano
2026-10-04 20:14 ` [PATCH v5] " Colin Hinton
2026-10-05 9:05 ` Matt Hunter
2026-10-05 13:07 ` Junio C Hamano
2026-10-06 3:22 ` [PATCH v6] " Colin Hinton
2026-10-07 16:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpkxua87a.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=colinlewishinton@gmail.com \
--cc=git@vger.kernel.org \
--cc=m@lfurio.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox