From: Junio C Hamano <gitster@pobox.com>
To: "Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Ben Knoble <ben.knoble@gmail.com>,
Phillip Wood <phillip.wood123@gmail.com>,
Harald Nordgren <haraldnordgren@gmail.com>
Subject: Re: [PATCH v3 0/2] ci: link failure and leak annotations to the test script
Date: Wed, 30 Sep 2026 07:37:13 -0700 [thread overview]
Message-ID: <xmqqpkxudcva.fsf@gitster.g> (raw)
In-Reply-To: <pull.2419.v3.git.git.1790748583.gitgitgadget@gmail.com> (Harald Nordgren via GitGitGadget's message of "Wed, 30 Sep 2026 06:09:41 +0000")
"Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com> writes:
> Link failure and leak annotations in CI to the test script, so both can be
> found from the job summary.
>
> V3 CI Job where failures and leaks are reported:
> https://github.com/git/git/actions/runs/36537917146/job/109306215909?pr=2426
>
> Changes in v3:
>
> * Fixed bug in the --immediate exit ordering: the --immediate &&
> --invert-exit-code path called exit 0 before the test's annotation was
> written, now a single unconditional call covers both exit paths.
> * github_escape_message_ no longer relies on \r being a portable sed escape
> sequence (not POSIX-guaranteed and BSD sed implementations can differ),
> it splices in the literal carriage-return byte via printf instead.
> * Reverted unrelated test-tool line back to its original form.
With these updates, the patches look good to me. Unless others
spot problems I failed to see, let me mark the topic for 'next'.
Thanks.
next prev parent reply other threads:[~2026-09-30 14:37 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 18:54 [PATCH] ci: point leak-sanitizer failures at the actual test and error Harald Nordgren via GitGitGadget
2026-09-25 20:26 ` Ben Knoble
2026-09-25 21:43 ` Harald Nordgren
2026-09-27 15:19 ` Phillip Wood
2026-09-27 19:52 ` Harald Nordgren
2026-09-28 18:54 ` [PATCH v2 0/2] ci: link failure and leak annotations to the test script Harald Nordgren via GitGitGadget
2026-09-28 18:54 ` [PATCH v2 1/2] ci: annotate leaks and stop a leak-sanitizer script at its first failure Harald Nordgren via GitGitGadget
2026-09-28 20:46 ` Junio C Hamano
2026-09-29 7:47 ` Harald Nordgren
2026-09-28 18:54 ` [PATCH v2 2/2] ci: point test failures and fixed known breakages at their file and line Harald Nordgren via GitGitGadget
2026-09-28 20:53 ` Junio C Hamano
2026-09-30 6:09 ` [PATCH v3 0/2] ci: link failure and leak annotations to the test script Harald Nordgren via GitGitGadget
2026-09-30 6:09 ` [PATCH v3 1/2] ci: annotate leaks and stop a leak-sanitizer script at its first failure Harald Nordgren via GitGitGadget
2026-09-30 14:56 ` Phillip Wood
2026-09-30 6:09 ` [PATCH v3 2/2] ci: point test failures and fixed known breakages at their file and line Harald Nordgren via GitGitGadget
2026-09-30 14:56 ` Phillip Wood
2026-09-30 18:40 ` Harald Nordgren
2026-09-30 14:37 ` Junio C Hamano [this message]
2026-09-30 15:52 ` [PATCH v3 0/2] ci: link failure and leak annotations to the test script Phillip Wood
2026-09-30 18:46 ` Junio C Hamano
2026-10-01 18:44 ` [PATCH v4 " Harald Nordgren via GitGitGadget
2026-10-01 18:44 ` [PATCH v4 1/2] ci: annotate leaks and stop a leak-sanitizer script at its first failure Harald Nordgren via GitGitGadget
2026-10-01 18:44 ` [PATCH v4 2/2] ci: point test failures and fixed known breakages at their file and line Harald Nordgren via GitGitGadget
2026-10-01 19:49 ` Phillip Wood
2026-10-01 20:11 ` Junio C Hamano
2026-10-02 8:04 ` Harald Nordgren
2026-10-03 8:11 ` [PATCH v5 0/2] ci: link failure and leak annotations to the test script Harald Nordgren via GitGitGadget
2026-10-03 8:11 ` [PATCH v5 1/2] ci: annotate leaks and stop a leak-sanitizer script at its first failure Harald Nordgren via GitGitGadget
2026-10-03 8:11 ` [PATCH v5 2/2] ci: point test failures and fixed known breakages at their file and line Harald Nordgren via GitGitGadget
2026-10-03 13:03 ` [PATCH v5 0/2] ci: link failure and leak annotations to the test script Phillip Wood
2026-10-03 19:02 ` Phillip Wood
2026-10-04 11:51 ` Harald Nordgren
2026-10-05 13:23 ` Phillip Wood
2026-10-05 13:59 ` Harald Nordgren
2026-10-05 15:11 ` Phillip Wood
2026-10-04 12:03 ` Harald Nordgren
2026-10-06 6:56 ` [PATCH v6 " Harald Nordgren via GitGitGadget
2026-10-06 6:56 ` [PATCH v6 1/2] ci: annotate leaks and stop a leak-sanitizer script at its first failure Harald Nordgren via GitGitGadget
2026-10-06 6:56 ` [PATCH v6 2/2] ci: point test failures and fixed known breakages at their file and line Harald Nordgren via GitGitGadget
2026-10-06 9:52 ` [PATCH v6 0/2] ci: link failure and leak annotations to the test script Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpkxudcva.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=haraldnordgren@gmail.com \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox