Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Shlok Kulshreshtha <diy2903@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 2/2] t: use commit_body to extract commit message bodies
Date: Wed, 29 Jul 2026 14:19:40 -0700	[thread overview]
Message-ID: <xmqqpl05o5n7.fsf@gitster.g> (raw)
In-Reply-To: <20260727095656.75496-3-diy2903@gmail.com> (Shlok Kulshreshtha's message of "Mon, 27 Jul 2026 15:26:56 +0530")

Shlok Kulshreshtha <diy2903@gmail.com> writes:

>  t/t3404-rebase-interactive.sh             |  2 +-
>  t/t3405-rebase-malformed.sh               |  8 +--
>  t/t3408-rebase-multi-line.sh              |  4 +-
>  t/t3434-rebase-i18n.sh                    |  3 +-
>  t/t3900-i18n-commit.sh                    |  4 +-
>  t/t4150-am.sh                             |  8 +--
>  t/t7500-commit-template-squash-signoff.sh |  4 +-
>  t/t7501-commit-basic-functionality.sh     | 21 +++----
>  t/t7502-commit-porcelain.sh               | 77 ++++++++---------------
>  t/t7509-commit-authorship.sh              | 23 +++----
>  t/t7600-merge.sh                          | 14 ++---
>  t/t7604-merge-custom-message.sh           | 18 ++----
>  t/t7614-merge-signoff.sh                  |  9 +--
>  13 files changed, 72 insertions(+), 123 deletions(-)

I would not claim to have checked all of these changes, but I did
spot check a handful and they all looked reasonable.

Shall we mark the topic for 'next'?

Thanks.

  reply	other threads:[~2026-07-29 21:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-26 22:48 [PATCH 0/2] t: add and use a commit_body test helper Shlok Kulshreshtha
2026-07-26 22:48 ` [PATCH 1/2] test-lib-functions: add commit_body helper Shlok Kulshreshtha
2026-07-26 22:48 ` [PATCH 2/2] t: use commit_body to extract commit message bodies Shlok Kulshreshtha
2026-07-27  8:15 ` [PATCH 0/2] t: add and use a commit_body test helper Junio C Hamano
2026-07-27  9:28   ` Shlok Kulshreshtha
2026-07-27  9:56   ` [PATCH v2 " Shlok Kulshreshtha
2026-07-27  9:56     ` [PATCH v2 1/2] test-lib-functions: add commit_body helper Shlok Kulshreshtha
2026-07-27  9:56     ` [PATCH v2 2/2] t: use commit_body to extract commit message bodies Shlok Kulshreshtha
2026-07-29 21:19       ` Junio C Hamano [this message]
2026-07-30 18:02         ` Shlok Kulshreshtha
2026-07-30 19:38           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpl05o5n7.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=diy2903@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox