From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH v2] SubmittingPatches: document how to retract a topic
Date: Wed, 08 Jul 2026 10:09:49 -0700 [thread overview]
Message-ID: <xmqqpl0xv25e.fsf@gitster.g> (raw)
In-Reply-To: <xmqqzf02xonc.fsf@gitster.g> (Junio C. Hamano's message of "Tue, 07 Jul 2026 18:20:55 -0700")
While this document outlines an idealized lifecycle where an author
develops a patch, refines it with reviewer feedback, and
successfully merges it into Git, reality is rarely so seamless.
Sometimes, a topic must be abandoned. Doing so explicitly is far
better than leaving it in limbo, especially since topics can always
be resurrected later.
Clearly state that we encourage contributors to retract any topic
that does not pan out.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
* Added the third bullet that talks about when and how a topic
becomes stalled and discarded.
Documentation/SubmittingPatches | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index d2d82eb543..c269e474e3 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -123,6 +123,20 @@ of review.
top, it gets merged to the 'master' branch and waits to become part
of the next major release.
+But sometimes things do not work as planned:
+
+. If a mailing list discussion convinces you that your changes aren't
+ ideal, please explicitly retract the topic to save the maintainer
+ time and effort.
+
+. If you must drop a topic due to shifting priorities, lack of time,
+ or other commitments, notify the list as a courtesy so others can
+ take over. Anyone can resurrect the topic later when they have the
+ capacity to do so.
+
+. Topics with unaddressed review comments that remain inactive for
+ four weeks may be discarded by the maintainer.
+
In the following sections, many techniques and conventions are listed
to help your patches get reviewed effectively in such a life cycle.
--
2.55.0-302-gdbd766b094
next prev parent reply other threads:[~2026-07-08 17:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 1:20 [PATCH] SubmittingPatches: abandoning a series Junio C Hamano
2026-07-08 17:09 ` Junio C Hamano [this message]
2026-07-08 18:23 ` [PATCH v2] SubmittingPatches: document how to retract a topic Michael Montalbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpl0xv25e.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox