Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Tamir Duberstein <tamird@gmail.com>,
	 git@vger.kernel.org,  Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH v2] describe: limit default ref iteration to tags
Date: Tue, 09 Jun 2026 06:23:31 -0700	[thread overview]
Message-ID: <xmqqpl1zsv8s.fsf@gitster.g> (raw)
In-Reply-To: <20260609110957.GB1509396@coredump.intra.peff.net> (Jeff King's message of "Tue, 9 Jun 2026 07:09:57 -0400")

Jeff King <peff@peff.net> writes:

> So while it is perhaps reasonable to document every detail in case
> somebody later wants to verify or reproduce timings, it is a little
> overwhelming when trying to tell a story, the core of which is:
>
>   In a repo with ~120k refs, ~300 of which were tags, running:
>
>     git describe --exact-match $some_tag
>
>   went from ~170ms to ~10ms, since we no longer needed to iterate all of
>   those other refs.
>
> That has _way_ less detail, but makes the point succinctly.
>
> I dunno. I am not trying to pick apart your commit in particular, but am
> more interested in the broader use of AI commit messages going forward.
> This kind of verbosity is quite common in the output (from my limited
> experience), and I think creates more work for reviewers. Should we be
> expecting contributors to make things more concise before submitting
> (either manually or through prompting)? Or do people even agree that the
> shorter version is preferable? I could be the only one.

Count me in.  You are the one who often gives us a patch with 60
lines that explains a single line change, but I haven't found these
60 lines are _overly verbose_ in the same way as AI generated log
messages.

  reply	other threads:[~2026-06-09 13:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09  2:32 [PATCH v2] describe: limit default ref iteration to tags Tamir Duberstein
2026-06-09 11:09 ` Jeff King
2026-06-09 13:23   ` Junio C Hamano [this message]
2026-06-09 13:40   ` D. Ben Knoble
2026-06-09 14:44   ` Tamir Duberstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpl1zsv8s.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    --cc=tamird@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox