Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Siddh Raman Pant <siddh.raman.pant@oracle.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
	 "newren@gmail.com" <newren@gmail.com>,  "ps@pks.im" <ps@pks.im>,
	 "code@khaugsbakk.name" <code@khaugsbakk.name>
Subject: Re: [PATCH 1/9] Documentation/git-range-diff: add missing notes options in synopsis
Date: Thu, 21 May 2026 09:28:59 +0900	[thread overview]
Message-ID: <xmqqpl2p38s4.fsf@gitster.g> (raw)
In-Reply-To: <b3958381907244ca06a39e2fc116eec113a6bc85.camel@oracle.com> (Siddh Raman Pant's message of "Wed, 20 May 2026 07:00:24 +0000")

Siddh Raman Pant <siddh.raman.pant@oracle.com> writes:

> On Wed, May 20 2026 at 05:17:51 +0530, Junio C Hamano wrote:
>> This has nothing to do with "external notes" topic, no?
>
> Yeah, but since I added the command line flag I found it doesn't
> mention the existing flags.
>
> Fixing it in the "external notes" commit would be bad, so I put it
> before that, since it also then provides a logical place to add new
> flags.

What I meant was that it would have been better as a standalone
patch that is unrelated to the (now) 8-patch topic for the external
notes.  That way, it can move faster without waiting for the rest.

Unless this patch has complex semantic or textual conflicts that
makes it easier to manage together with the external notes series,
that is.  I think adding [--notes=...] to one existing line (this
patch) and adding a new line with [--[no-]external] on it (the main
part of the topic) can be done in parallel and it is not too much to
ask for the integrator to merge them on the receiving end.

Thanks.




  reply	other threads:[~2026-05-21  0:29 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 16:30 [PATCH 0/9] Add support for an external command for fetching notes Siddh Raman Pant
2026-05-19 16:30 ` [PATCH 1/9] Documentation/git-range-diff: add missing notes options in synopsis Siddh Raman Pant
2026-05-19 23:47   ` Junio C Hamano
2026-05-20  7:00     ` Siddh Raman Pant
2026-05-21  0:28       ` Junio C Hamano [this message]
2026-05-21  4:13         ` Siddh Raman Pant
2026-05-19 16:30 ` [PATCH 2/9] notes: convert raw arg in format_display_notes() to bool Siddh Raman Pant
2026-05-19 16:30 ` [PATCH 3/9] wrapper: add sleep_nanosec Siddh Raman Pant
2026-05-19 23:50   ` Junio C Hamano
2026-05-20  7:07     ` Siddh Raman Pant
2026-05-19 16:30 ` [PATCH 4/9] run-command: add support for timeout in command finisher Siddh Raman Pant
2026-05-21  7:21   ` Johannes Sixt
2026-05-21  8:39     ` Oswald Buddenhagen
2026-05-21  9:59     ` Siddh Raman Pant
2026-05-21 14:36       ` Johannes Sixt
2026-05-19 16:30 ` [PATCH 5/9] wrapper: add support for timeout and deadline in read helpers Siddh Raman Pant
2026-05-19 16:30 ` [PATCH 6/9] t3301: cover generic displayed notes behavior Siddh Raman Pant
2026-05-19 16:30 ` [PATCH 7/9] notes: support an external command to display notes Siddh Raman Pant
2026-05-20  0:03   ` Junio C Hamano
2026-05-20  6:59     ` Siddh Raman Pant
2026-05-21  1:12   ` brian m. carlson
2026-05-21  4:12     ` Siddh Raman Pant
2026-05-21 21:18       ` brian m. carlson
2026-05-19 16:30 ` [PATCH 8/9] Documentation: document external notes command options Siddh Raman Pant
2026-05-19 16:30 ` [PATCH 9/9] t: add tests for external notes command Siddh Raman Pant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpl2p38s4.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=code@khaugsbakk.name \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    --cc=ps@pks.im \
    --cc=siddh.raman.pant@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox