From: Junio C Hamano <gitster@pobox.com>
To: Quentin Bernet <quentin.bernet@bluewin.ch>
Cc: Mirko Faina <mroik@delayed.space>,
"D. Ben Knoble" <ben.knoble@gmail.com>,
Quentin Bernet via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] docs: fix git stash grammar
Date: Fri, 27 Mar 2026 10:45:12 -0700 [thread overview]
Message-ID: <xmqqpl4pjhef.fsf@gitster.g> (raw)
In-Reply-To: <6b5a5bd8-0631-4c1b-b87b-c75d99dc9c50@bluewin.ch> (Quentin Bernet's message of "Fri, 27 Mar 2026 18:36:54 +0100")
Quentin Bernet <quentin.bernet@bluewin.ch> writes:
[administrivia] don't top post.
> I'm assuming "#leftoverbits" means "this is something that would be
> nice, but which is for another time"
> And I'll leave the pleasure of implementing that to someone more
> well-versed in C and git internals !
>
>
> Therefore my previous change (current status of the github PR) works, as
> a reminder, here it is:
> ...
>
> diff --git a/Documentation/git-stash.adoc b/Documentation/git-stash.adoc
> ...
> git stash clear
> ...
> Is there something else I should do ?
Without any additional effort on top of what we saw in the previous
patch, I am not sure if ...
>> ... It would be sufficient to make sure the readers understand
>> that they may have to disambiguate pathspec with "--" like any other
>> command (like "git log foo" when you have both file "foo" and tag
>> "foo") in the description part.
... is already achieved.
Also, my earlier "if the log message said ..., we wouldn't be having
this long thread" comment still stands.
https://lore.kernel.org/git/xmqqqzp5mfh5.fsf@gitster.g/
Thanks.
next prev parent reply other threads:[~2026-03-27 17:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 12:45 [PATCH] docs: fix git stash grammar Quentin Bernet via GitGitGadget
2026-03-26 16:17 ` D. Ben Knoble
2026-03-27 0:04 ` Mirko Faina
2026-03-27 15:58 ` Junio C Hamano
2026-03-27 16:28 ` Quentin Bernet
2026-03-27 16:53 ` Junio C Hamano
2026-03-27 16:58 ` Quentin Bernet
2026-03-27 17:16 ` Junio C Hamano
2026-03-27 17:36 ` Quentin Bernet
2026-03-27 17:45 ` Junio C Hamano [this message]
2026-03-27 16:47 ` Ben Knoble
2026-03-27 8:25 ` Quentin Bernet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpl4pjhef.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=mroik@delayed.space \
--cc=quentin.bernet@bluewin.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox