From: Junio C Hamano <gitster@pobox.com>
To: "Jayesh Daga via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Justin Tobler <jltobler@gmail.com>,
Ayush Chandekar <ayu.chandekar@gmail.com>,
Siddharth Asthana <siddharthasthana31@gmail.com>,
Jayesh Daga <jayeshdaga99@gmail.com>
Subject: Re: [PATCH] t/t2107-update-index-basic: use test_path_is_missing
Date: Sun, 22 Mar 2026 14:55:47 -0700 [thread overview]
Message-ID: <xmqqpl4v7cm4.fsf@gitster.g> (raw)
In-Reply-To: <pull.2250.git.git.1774197600379.gitgitgadget@gmail.com> (Jayesh Daga via GitGitGadget's message of "Sun, 22 Mar 2026 16:40:00 +0000")
"Jayesh Daga via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: jayesh0104 <jayeshdaga99@gmail.com>
The author identifier (name and email) used here to identify the
author must match the identifier used to sign-off. You'd probably
need to "git commit --amend --reset-author" this commit with updatec
user.name set to "Jayesh Daga", not "jayesh0104" or something.
>
> Replace a raw '! test -f' check with test_path_is_missing to
> use the standard test helper and improve consistency with
> other tests.
>
> Signed-off-by: Jayesh Daga <jayeshdaga99@gmail.com>
> ---
> t/t2107-update-index-basic.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t2107-update-index-basic.sh b/t/t2107-update-index-basic.sh
> index cc72ead79f..3bffe5da8a 100755
> --- a/t/t2107-update-index-basic.sh
> +++ b/t/t2107-update-index-basic.sh
> @@ -86,7 +86,7 @@ test_expect_success '.lock files cleaned up' '
> # the_index.cache_changed is zero, rollback_lock_file fails
> git update-index --refresh --verbose >out &&
> test_must_be_empty out &&
> - ! test -f .git/index.lock
> + test_path_is_missing .git/index.lock
> )
> '
>
>
> base-commit: 6e8d538aab8fe4dd07ba9fb87b5c7edcfa5706ad
prev parent reply other threads:[~2026-03-22 21:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-22 16:40 [PATCH] t/t2107-update-index-basic: use test_path_is_missing Jayesh Daga via GitGitGadget
2026-03-22 21:55 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpl4v7cm4.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ayu.chandekar@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jayeshdaga99@gmail.com \
--cc=jltobler@gmail.com \
--cc=siddharthasthana31@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox