From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, fastcat@gmail.com,
Eric Sunshine <sunshine@sunshineco.com>,
Patrick Steinhardt <ps@pks.im>,
Phillip Wood <phillip.wood123@gmail.com>,
Derrick Stolee <stolee@gmail.com>
Subject: Re: [PATCH v3 1/4] for-each-repo: test outside of repo context
Date: Mon, 02 Mar 2026 10:31:52 -0800 [thread overview]
Message-ID: <xmqqpl5m13s7.fsf@gitster.g> (raw)
In-Reply-To: <20260302175606.GB28275@coredump.intra.peff.net> (Jeff King's message of "Mon, 2 Mar 2026 12:56:06 -0500")
Jeff King <peff@peff.net> writes:
> On Mon, Mar 02, 2026 at 03:36:42PM +0000, Derrick Stolee via GitGitGadget wrote:
>
>> test_description='git for-each-repo builtin'
>>
>> +# We need to test running 'git for-each-repo' outside of a repo context.
>> +TEST_NO_CREATE_REPO=1
>> +
>> . ./test-lib.sh
>
> Interesting. I was going to point out that this won't do what you want
> by itself, because Git will keep walking out of the trash directory and
> may find the containing repository.
>
> But it looks like this should be enough due to 614c3d8f2e (test-lib: set
> GIT_CEILING_DIRECTORIES to protect the surrounding repository,
> 2021-08-29). Supporting this case wasn't the intent of that patch, but I
> don't see any reason why it should not work reliably.
I am surprised that use of GIT_CEILING_DIRECTORIES was not done
until 2021, actually. The reason the configuration variable was
invented for is exactly to avoid discovery processes going upward
and ending up in a repository different from what we mean to work
with.
next prev parent reply other threads:[~2026-03-02 18:31 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 3:32 [PATCH 0/2] for-each-repo: work correctly in a worktree Derrick Stolee via GitGitGadget
2026-02-24 3:32 ` [PATCH 1/2] for-each-repo: stop using the_repository Derrick Stolee via GitGitGadget
2026-02-24 9:18 ` Patrick Steinhardt
2026-02-24 12:07 ` Derrick Stolee
2026-02-24 3:32 ` [PATCH 2/2] for-each-repo: work correctly in a worktree Derrick Stolee via GitGitGadget
2026-02-24 3:34 ` Eric Sunshine
2026-02-24 9:18 ` Jeff King
2026-02-24 12:11 ` Derrick Stolee
2026-02-25 13:23 ` Jeff King
2026-02-24 9:18 ` Patrick Steinhardt
2026-02-24 21:35 ` [PATCH v2 0/2] " Derrick Stolee via GitGitGadget
2026-02-24 21:35 ` [PATCH v2 1/2] for-each-repo: test outside of repo context Derrick Stolee via GitGitGadget
2026-02-24 21:35 ` [PATCH v2 2/2] for-each-repo: work correctly in a worktree Derrick Stolee via GitGitGadget
2026-02-24 21:47 ` Junio C Hamano
2026-02-25 11:44 ` Derrick Stolee
2026-02-25 13:13 ` Jeff King
2026-02-26 15:29 ` Derrick Stolee
2026-02-26 16:21 ` Junio C Hamano
2026-02-26 18:14 ` Phillip Wood
2026-02-27 19:41 ` Junio C Hamano
2026-02-27 22:28 ` Derrick Stolee
2026-02-27 22:45 ` Jeff King
2026-02-27 22:42 ` Jeff King
2026-03-02 15:31 ` Derrick Stolee
2026-03-02 18:09 ` Jeff King
2026-03-02 15:36 ` [PATCH v3 0/4] " Derrick Stolee via GitGitGadget
2026-03-02 15:36 ` [PATCH v3 1/4] for-each-repo: test outside of repo context Derrick Stolee via GitGitGadget
2026-03-02 17:56 ` Jeff King
2026-03-02 18:31 ` Junio C Hamano [this message]
2026-03-02 18:36 ` Derrick Stolee
2026-03-02 15:36 ` [PATCH v3 2/4] run-command: extract clear_local_repo_env helper Derrick Stolee via GitGitGadget
2026-03-02 18:03 ` Jeff King
2026-03-02 18:35 ` Junio C Hamano
2026-03-02 18:37 ` Derrick Stolee
2026-03-02 15:36 ` [PATCH v3 3/4] for-each-repo: work correctly in a worktree Derrick Stolee via GitGitGadget
2026-03-02 18:06 ` Jeff King
2026-03-02 18:39 ` Derrick Stolee
2026-03-02 21:32 ` Junio C Hamano
2026-03-02 15:36 ` [PATCH v3 4/4] for-each-repo: simplify passing of parameters Derrick Stolee via GitGitGadget
2026-03-02 18:06 ` Jeff King
2026-03-03 17:31 ` [PATCH v4 0/4] for-each-repo: work correctly in a worktree Derrick Stolee via GitGitGadget
2026-03-03 17:31 ` [PATCH v4 1/4] for-each-repo: test outside of repo context Derrick Stolee via GitGitGadget
2026-03-03 17:31 ` [PATCH v4 2/4] run-command: extract sanitize_repo_env helper Derrick Stolee via GitGitGadget
2026-03-03 17:31 ` [PATCH v4 3/4] for-each-repo: work correctly in a worktree Derrick Stolee via GitGitGadget
2026-03-03 17:31 ` [PATCH v4 4/4] for-each-repo: simplify passing of parameters Derrick Stolee via GitGitGadget
2026-03-05 1:20 ` [PATCH v4 0/4] for-each-repo: work correctly in a worktree Jeff King
2026-03-05 6:14 ` Patrick Steinhardt
2026-03-05 17:23 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpl5m13s7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=fastcat@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=peff@peff.net \
--cc=phillip.wood123@gmail.com \
--cc=ps@pks.im \
--cc=stolee@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox