public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com>,
	 git@vger.kernel.org
Subject: Re: [RFC PATCH] t5500-fetch-pack.sh: fix suppression of Git exit code in tests
Date: Mon, 12 Jan 2026 05:25:12 -0800	[thread overview]
Message-ID: <xmqqpl7fnetj.fsf@gitster.g> (raw)
In-Reply-To: <aWSv8dlt32xg14e1@pks.im> (Patrick Steinhardt's message of "Mon, 12 Jan 2026 09:25:21 +0100")

Patrick Steinhardt <ps@pks.im> writes:

> On Sun, Jan 11, 2026 at 02:50:37PM -0800, Junio C Hamano wrote:
>> Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com> writes:
>> >  	GIT_PROTOCOL=version=2 git upload-pack . <<-EOF >/dev/null
>> >  	0012command=fetch
>> > -	$(echo "object-format=$(test_oid algo)" | packetize)
>> > +	$(echo "object-format=$(<oid_algo)" | packetize)
>> 
>> The construct $(<file) is bashism, that does not work if your shell
>> is not bash, isn't it?  If you used a variable, e.g.,
>> 
>> 	$(echo "object-format=$oid_algo" | packetize)
>> 
>> that would make the result more portable.
>
> There's no need for the echo at all as this can also be written as:
>
>     packetize "object-format=$oid_algo"

Yeah, I failed to realize that this is a(n unnecessarily) convoluted
use of command substitution inside HERE-DOC.  What mushroom were we
on when we originally wrote this crap, I have to wonder ;-)?

Thanks for spotting it.

  parent reply	other threads:[~2026-01-12 13:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-11 20:00 [RFC PATCH] t5500-fetch-pack.sh: fix suppression of Git exit code in tests Shreyansh Paliwal
2026-01-11 22:50 ` Junio C Hamano
2026-01-12  8:21   ` Shreyansh Paliwal
2026-01-12  8:25   ` Patrick Steinhardt
2026-01-12  9:11     ` t5500-fetch-pack.sh and exit-code suppression Shreyansh Paliwal
2026-01-12 13:25     ` Junio C Hamano [this message]
2026-01-13  9:53       ` [RFC PATCH] t5500-fetch-pack.sh: fix suppression of Git exit code in tests Shreyansh Paliwal
2026-01-13 13:40         ` Junio C Hamano
2026-01-13 17:53           ` [GSOC][PATCH] t5500: simplify test implementation and fix git exit code suppression Shreyansh Paliwal
2026-01-15 21:28             ` Shreyansh Paliwal
2026-01-20 16:44             ` Junio C Hamano
2026-01-21 12:54               ` [GSOC][PATCH V2] " Shreyansh Paliwal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpl7fnetj.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    --cc=shreyanshpaliwalcmsmn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox