From: Junio C Hamano <gitster@pobox.com>
To: Toon Claes <toon@iotcl.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Karthik Nayak <karthik.188@gmail.com>,
Anders Kaseorg <andersk@MIT.EDU>
Subject: Re: [PATCH v2] last-modified: fix use of uninitialized memory
Date: Tue, 09 Dec 2025 21:18:06 +0900 [thread overview]
Message-ID: <xmqqpl8nkfwh.fsf@gitster.g> (raw)
In-Reply-To: <871pl4vyd5.fsf@iotcl.com> (Toon Claes's message of "Tue, 09 Dec 2025 09:43:50 +0100")
Toon Claes <toon@iotcl.com> writes:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Sorry, but hasn't the old one already been cooking in 'next'?
>
> Okay, fine by me. Let's abandon this v2 then.
Understood. I however agree with Patrick that rewriting
memset(ptr, '\0', sizeof(*ptr) * nr)
to use CLEAR_ARRAY(), not limited to last-modified but everywhere in
the codebase, may not be a bad idea. It would be a good exercise to
hone our Coccinelle skill ;-)
prev parent reply other threads:[~2025-12-09 12:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 16:37 [PATCH] last-modified: fix bug caused by inproper initialized memory Toon Claes
2025-11-28 20:55 ` Jeff King
2025-11-28 22:20 ` Anders Kaseorg
2025-11-29 10:50 ` Jeff King
2025-12-08 11:47 ` Toon Claes
2025-12-08 20:15 ` Jeff King
2025-12-08 22:42 ` Junio C Hamano
2025-11-29 2:01 ` Junio C Hamano
2025-11-29 2:11 ` Junio C Hamano
2025-11-29 9:38 ` Toon Claes
2025-12-08 11:46 ` [PATCH v2] last-modified: fix use of uninitialized memory Toon Claes
2025-12-08 13:26 ` Junio C Hamano
2025-12-09 8:43 ` Toon Claes
2025-12-09 12:18 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpl8nkfwh.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=andersk@MIT.EDU \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=peff@peff.net \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).