From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a5-smtp.messagingengine.com (fhigh-a5-smtp.messagingengine.com [103.168.172.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4490B2F7ABA for ; Fri, 5 Sep 2025 15:37:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.156 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757086652; cv=none; b=g16yb9zBMzq4ZQ8FeGeMTZKqlqX02KP0DKhkf0CTeFFWU0tIXwM5/neexuNlw4rXkZAAGTG9PVtPMjwQzxeC/TlzvcuBPJff/fQL8aWelnSvhYPTOE0Mx9pqHwgJBwke8+ey6L66ugcE1T0GrRkrYsrSyjhMJZ5Kh9urvDV+HOE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757086652; c=relaxed/simple; bh=MJZb9WgtR26ibaCX09lOT9hjMA4Z8tTr4ZXRgwwKmtk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=AC1jzD+0CWJ6DynfL0PbFUJZ370RjmSswEfDbtg3eskvLSxpl65ooCjWuOH6TgnMaJbgADfR3COqEcMDkrfaSS2Di1AebWzI4qhw6hZfiXZrK7GFidjVpZp9Dc00eTrXtw0vVx3dDlPdkO/LFFLOUI2O8EVRXG/97Lp1wgyXmsc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b=2ieVHICY; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=jX9WV7T7; arc=none smtp.client-ip=103.168.172.156 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b="2ieVHICY"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="jX9WV7T7" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfhigh.phl.internal (Postfix) with ESMTP id 6507314002A8; Fri, 5 Sep 2025 11:37:30 -0400 (EDT) Received: from phl-frontend-01 ([10.202.2.160]) by phl-compute-04.internal (MEProxy); Fri, 05 Sep 2025 11:37:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1757086650; x=1757173050; bh=kWmy6meMx+ pAXv5lEJkb24QvaplPwvl8I4dpu14ggpc=; b=2ieVHICY9pRoKW8MI0uIuw5OO0 8s6WUdD2im8M8SdHHv4nOMcE5mLNMpjcGvGlXcO55Heq7nHC7xCMtE0YKRwpDPm5 2shxLetA5rI04Pd/4pBwn/xDLyVoSKyBKtmrvd5UwMcEkimlEq0dzg6Fg+OU+jBw +YoTY82TVkO6Lj0LyN0/YHeDE12YR/+UqKn0yL67NBpyv8vlAiKfIETESWHQZlhY U+WQl0wFprLgkUGbZuIZKXLTYOJbjE1InX7eWD1g4HlXUtvRBOyFZs7XeYVlvrs2 8Q4gVJEmaBVCE4+DtaQWv4Pakc7T0hi+27vuVbhalwOx6IgqAwvMwRs4BrZQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1757086650; x=1757173050; bh=kWmy6meMx+pAXv5lEJkb24QvaplPwvl8I4d pu14ggpc=; b=jX9WV7T7hCj9Lh2NN8pL1wq1jah9yaPZtHrrc+EMJqz7WCCBPRU gAhb3ggPAjSH3V4kK2iv8crNHCD0vnFmj+Arr3kkWVyN4WEyniIguY0zC+VCZbu4 vrK4uazC+j/ukahZzOpm/FnSjjbEr610UOqXWNW51VRq5l6cEP2JAFV4v/HOYivB Cl85AWneIcHEn9Oz6fYadW3xuWae2VkgfqMD4SCTis9cXmjNnfRm4iHoVSmmWCC1 3GnEmdJXA6GStXFji5Lwohj5jHX91wNYbByGre66ZPLtdAdKLR5q92gyBf7wQ0pK CiLOt7Vm0nfR6sFMgGSQIcN0EhLZzXvSC/Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdelvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvvefujghffffkfgggtgesthdtredttdertdenucfhrhhomheplfhunhhiohcuvecu jfgrmhgrnhhouceoghhithhsthgvrhesphhosghogidrtghomheqnecuggftrfgrthhtvg hrnhepfeevteetjeehueegffelvdetieevffeufeejleeuffetiefggfeftdfhfeeigeei necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhith hsthgvrhesphhosghogidrtghomhdpnhgspghrtghpthhtohepvdegpdhmohguvgepshhm thhpohhuthdprhgtphhtthhopehphhhilhhlihhprdifohhougduvdefsehgmhgrihhlrd gtohhmpdhrtghpthhtohepnhgvfihrvghnsehgmhgrihhlrdgtohhmpdhrtghpthhtohep phhssehpkhhsrdhimhdprhgtphhtthhopehsrghnuggrlhhssegtrhhushhthihtohhoth hhphgrshhtvgdrnhgvthdprhgtphhtthhopehmvgesthhtrgihlhhorhhrrdgtohhmpdhr tghpthhtoheprhhssggvtghkvghrsehnvgigsghrihgughgvrdgtohhmpdhrtghpthhtoh epkhhrihhsthhofhhfvghrhhgruhhgshgsrghkkhesfhgrshhtmhgrihhlrdgtohhmpdhr tghpthhtohepghhithhgihhtghgrughgvghtsehgmhgrihhlrdgtohhmpdhrtghpthhtoh epghhithesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: if26b431b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 5 Sep 2025 11:37:28 -0400 (EDT) From: Junio C Hamano To: Phillip Wood Cc: Elijah Newren , Patrick Steinhardt , "brian m. carlson" , Taylor Blau , rsbecker@nexbridge.com, Kristoffer Haugsbakk , Josh Soref , git@vger.kernel.org, Christian Brabandt , Eli Schwartz , "Haelwenn (lanodan) Monnier" , Johannes Schindelin , Matthias =?utf-8?Q?A=C3=9Fhauer?= , Sam James , Collin Funk , Mike Hommey , Pierre-Emmanuel Patry , "D. Ben Knoble" , Ramsay Jones , Ezekiel Newren , Josh Steadmon , Calvin Wan Subject: Re: [PATCH v3 02/15] xdiff: introduce rust In-Reply-To: (Phillip Wood's message of "Fri, 5 Sep 2025 14:14:43 +0100") References: <01f101dc1760$5eef42b0$1ccdc810$@nexbridge.com> Date: Fri, 05 Sep 2025 08:37:27 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Phillip Wood writes: > This release introduces an optional dependency on rust that is > enabled by default. Platforms without a rust compiler can continue > to build git by passing NO_RUST=1. In six months time we plan to > make rust mandatory for building git. From that point git 2.x.y (the > last version that can be built without rust) will continue to > receive security updates for three years. > > To me the important elements are: > > 1) There is a short period where rust is optional. This allows > (i) Distributors on platforms without a rust compiler time to notify > their users that in the future they will only be able to offer > security updates. > (ii) Distributors on platforms with a rust compiler time to adjust > their build procedures to include rust. > (iii) The git project time to gain experience of using rust and writing > the necessary bindings while building with it is optional. Good. I am not sure "short" should be an important element, but having a known and agreed-upon deadline helps. > 2) Rust is enabled by default so platforms without a rust compiler are > made aware of the problem but have an easy way to continue to build > git while rust is optional. Obviously there is nothing to disagree with here, as it is the definition of the word "optional" ;-). > 3) There is a period of a small number of years where we continue to > provide security updates for a version of git that can be built > without rust. This is intended to allow a realistic time for > distributors on platforms without a rust compiler to port one or make > other arrangements for providing future security updates without > placing an undue burden on the project to provide security updates > for niche platforms indefinitely. I am not willing to see such a support for multiple years, though. If the first item is 6 months, this backporting stale releases should be on the same order of timeperiod. If it were "3 years of optional period, 18 months of backporting security updates", I would find it more realistic. It would give those platform maintainers enough time to robby, fundraise, or otherwise campaign to bring Rust on their system. I personally find that 6 months is way too short (if we are _only_ looking for an excuse to say "we have given them ample time to react, and now it is their problem", 6 months may be good enough, though).