From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] ls-files: conditionally leave index sparse
Date: Thu, 28 Aug 2025 08:02:06 -0700 [thread overview]
Message-ID: <xmqqplcfxzf5.fsf@gitster.g> (raw)
In-Reply-To: <5c19f2f4-1d04-424d-9720-6db4342aebdd@gmail.com> (Derrick Stolee's message of "Wed, 27 Aug 2025 15:36:18 -0400")
Derrick Stolee <stolee@gmail.com> writes:
> On 8/26/2025 12:40 PM, Derrick Stolee wrote:
>> On 8/15/2025 12:12 PM, Derrick Stolee via GitGitGadget wrote:
>>> From: Derrick Stolee <stolee@gmail.com>
>> ...
>>> Replace this global check to expand the index with a check inside the
>>> loop for a matched sparse directory. If we see one, then expand the
>>> index and continue from the current location. This is safe since the
>>> previous entries in the index did not have any sparse directories and
>>> thus would remain stable in this expansion.
>> ...> Here's a small sparse index performance update based on a user report.
>>
>> I know this is small and somewhat niche, but it hasn't had any review
>> or been picked up in What's Cooking. Could someone please take a look?
>
> Thanks, Elijah and Junio for reviewing.
>
> By coincidence, a user reported an issue where the sparse index was
> expanded during "git mergetool" and it was due to a pathspec-focused
> ls-files subcommand. So maybe it's less niche than I had thought.
I do not speak for others who did not comment on the thread, but the
reason I did not act on the message was not because I found it niche
or insignificant. I simply missed the single message in the sea of
other threads.
Queued. Thanks for pinging.
next prev parent reply other threads:[~2025-08-28 15:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 16:12 [PATCH] ls-files: conditionally leave index sparse Derrick Stolee via GitGitGadget
2025-08-26 16:40 ` Derrick Stolee
2025-08-27 19:36 ` Derrick Stolee
2025-08-28 15:02 ` Junio C Hamano [this message]
2025-08-26 18:37 ` Elijah Newren
2025-08-26 19:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqplcfxzf5.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=newren@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).