git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Aditya Garg <gargaditya08@live.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
	 Eric Sunshine <sunshine@sunshineco.com>,
	 Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>,
	 Ben Knoble <ben.knoble@gmail.com>,
	"brian m. carlson" <sandals@crustytoothpaste.net>
Subject: Re: [PATCH v2] send-email: add ability to send a copy of sent emails to an IMAP folder
Date: Mon, 21 Jul 2025 12:13:56 -0700	[thread overview]
Message-ID: <xmqqpldtxsp7.fsf@gitster.g> (raw)
In-Reply-To: <87a890182591c9c21061e85834fc99a766252611.1753092192.git.gargaditya08@live.com> (Aditya Garg's message of "Mon, 21 Jul 2025 10:05:39 +0000")

Aditya Garg <gargaditya08@live.com> writes:

> +sendemail.imapfolder::

Do we expect that the use of IMAP in git-send-email will be limited
forever to store outgoing e-mails to the Sent folder?  I highly
doubt it.  For example, would it be plausible that given send-email
has so much richer feature set compared to imap-send, it would not
be implausible for users of imap-send that want to stuff messages,
with Cc's, threading, etc., all prepared by send-email, to their
outgoing folder.

And when somebody wants to add such a feature to "git send-email",
how would they find this variable that uses imap-send for quite a
different purpose squatting on its name?

Same comment for the --imap-folder command line option and the
internal variable(s) used to implement this feature.

These things should be named with words like "sent", "fcc", etc., to
clarify the use case this new feature is trying to support.

As imap-send is not part of my daily workflow, I have no strong
opinions for or against the proposed feature, and I didn't find
anything glaringly wrong in the implementation, other than the poor
naming that would block possible future enhancements.

Thanks.


  parent reply	other threads:[~2025-07-21 19:13 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-20  9:25 [PATCH] send-email: add ability to send a copy of sent emails to an IMAP folder Aditya Garg
2025-07-21 10:05 ` [PATCH v2] " Aditya Garg
2025-07-21 16:34   ` Eric Sunshine
2025-07-23  9:48     ` Aditya Garg
2025-07-21 19:13   ` Junio C Hamano [this message]
2025-07-22  0:19     ` brian m. carlson
2025-07-22  3:40       ` Aditya Garg
2025-07-22  3:37     ` Aditya Garg
2025-07-22  5:09       ` Junio C Hamano
2025-07-22  6:14         ` Aditya Garg
2025-07-22 11:24           ` Aditya Garg
2025-07-22 15:36             ` Junio C Hamano
2025-07-22 16:31               ` Aditya Garg
2025-07-22 16:36                 ` Aditya Garg
2025-07-22 17:23                 ` Junio C Hamano
2025-07-22 17:26                   ` Aditya Garg
2025-07-22 13:24           ` Junio C Hamano
2025-07-22 13:26             ` Aditya Garg
2025-07-22 11:14 ` [PATCH v3] " Aditya Garg
2025-07-23  9:05   ` Aditya Garg
2025-07-23 10:33 ` [PATCH v4 0/2] send-email: integrate with git imap-send Aditya Garg
2025-07-23 10:33   ` [PATCH v4 1/2] send-email: add ability to send a copy of sent emails to an IMAP folder Aditya Garg
2025-07-23 10:33   ` [PATCH v4 2/2] send-email: enable copying emails to IMAP folder without actually sending them Aditya Garg
2025-08-11 21:52     ` Junio C Hamano
2025-08-12  5:08       ` Aditya Garg
2025-08-12  6:27         ` Aditya Garg
2025-08-12 14:15           ` Junio C Hamano
2025-08-12  6:51       ` Aditya Garg
2025-08-12  6:44 ` [PATCH v5 0/2] send-email: integrate with git imap-send Aditya Garg
2025-08-12  6:44   ` [PATCH v5 1/2] send-email: add ability to send a copy of sent emails to an IMAP folder Aditya Garg
2025-08-12  6:44   ` [PATCH v5 2/2] send-email: enable copying emails to an IMAP folder without actually sending them Aditya Garg
2025-08-12 16:00   ` [PATCH v5 0/2] send-email: integrate with git imap-send Junio C Hamano
2025-08-15  3:38   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpldtxsp7.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ben.knoble@gmail.com \
    --cc=gargaditya08@live.com \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=sandals@crustytoothpaste.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).