From: Junio C Hamano <gitster@pobox.com>
To: Peter Seiderer <ps.report@gmx.net>
Cc: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Subject: Re: Meson build leaks host 'sh' path to target build when cross-compiled
Date: Mon, 10 Feb 2025 11:54:25 -0800 [thread overview]
Message-ID: <xmqqpljpa83y.fsf@gitster.g> (raw)
In-Reply-To: <20250210174335.6d6d2af2@gmx.net> (Peter Seiderer's message of "Mon, 10 Feb 2025 17:43:35 +0100")
Peter Seiderer <ps.report@gmx.net> writes:
> Maybe all doing (autoconf) cross builds where happy with the defaults
> from the Makefile (SHELL_PATH = /bin/sh, PERL_PATH = /usr/bin/perl)
> on host and target (as the buildroot autoconf package since 2013) and
> only users doing native builds fiddled around with non-default values?
I somehow doubt it.
The problem I see is that there is no distinction between "this is
the path for the shell on the target system" vs "this is the shell
we run on the host while building the package" in the Makefile. Use
of autoconf would not magically change it; the Makefile that
includes the config.mak.autogen needs to be aware of the
distinction.
next prev parent reply other threads:[~2025-02-10 19:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-09 12:30 Meson build leaks host 'sh' path to target build when cross-compiled Peter Seiderer
2025-02-10 7:41 ` Patrick Steinhardt
2025-02-10 11:26 ` Peter Seiderer
2025-02-18 11:47 ` Patrick Steinhardt
2025-02-18 14:41 ` Eli Schwartz
2025-02-10 16:18 ` Junio C Hamano
2025-02-10 16:43 ` Peter Seiderer
2025-02-10 19:54 ` Junio C Hamano [this message]
2025-02-11 8:55 ` Peter Seiderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpljpa83y.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps.report@gmx.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).