From: Junio C Hamano <gitster@pobox.com>
To: "Jean-Noël Avila" <jean-noel.avila@scantech.com>
Cc: "Jean-Noël Avila via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] doc: git-add.txt: convert to new style convention
Date: Wed, 13 Nov 2024 07:41:02 +0900 [thread overview]
Message-ID: <xmqqpln03wjl.fsf@gitster.g> (raw)
In-Reply-To: <0882542f-8424-4dfc-8358-f5c982aafbd4@scantech.com> ("Jean-Noël Avila"'s message of "Tue, 12 Nov 2024 10:25:10 +0100")
Jean-Noël Avila <jean-noel.avila@scantech.com> writes:
>> This does slightly more than converting to new style, though,
>> doesn't it? Is it so annoying to see a link that points at the same
>> page you are reading right now to warrant duplicating some docs with
>> conditional inclusion?
> ...
> This was already performed for git-clone (ebb55042a4) and git-init
> (e7b3a7683c). Should it be separated in a dedicated commit?
My comment came primarily as a reaction to seeing this change that
was not part of what the proposed log message said. As you say, as
a separate and orthogonal thing, we could make it a separate commit.
But it also is perfectly fine if the log message explained that we
are doing this independent change "while we are at it".
Thanks.
next prev parent reply other threads:[~2024-11-12 22:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 18:14 [PATCH] doc: git-add.txt: convert to new style convention Jean-Noël Avila via GitGitGadget
2024-11-12 0:38 ` Junio C Hamano
2024-11-12 9:25 ` Jean-Noël Avila
2024-11-12 22:41 ` Junio C Hamano [this message]
2024-11-16 21:42 ` [PATCH v2] " Jean-Noël Avila via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpln03wjl.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jean-noel.avila@scantech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).