From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t1517: more coverage for commands that work without repository
Date: Fri, 31 May 2024 07:57:47 -0700 [thread overview]
Message-ID: <xmqqplt2hvv8.fsf@gitster.g> (raw)
In-Reply-To: <Zlmz9Edyv_gehMVr@tanuki> (Patrick Steinhardt's message of "Fri, 31 May 2024 13:26:44 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> On Thu, May 30, 2024 at 09:58:46AM -0700, Junio C Hamano wrote:
> [snip]
>> +test_expect_success 'stripspace outside repository' '
>> + nongit git stripspace -s </dev/null
>> +'
>
> I was wondering whether we also want to verify that it does the correct
> thing here as it's comparatively easy:
> ...
> For the other tests it's a bit more involved. And given that these are
> all designed as smoke tests, I think it's fine overall.
Yup, as I said in the proposed log message, we may want to update
them to actually do something useful later, but this would at least
help us catch regressions by mistake.
prev parent reply other threads:[~2024-05-31 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 16:58 [PATCH] t1517: more coverage for commands that work without repository Junio C Hamano
2024-05-31 8:43 ` [PATCH v2] " Junio C Hamano
2024-05-31 11:26 ` [PATCH] " Patrick Steinhardt
2024-05-31 14:57 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqplt2hvv8.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).