From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] format-patch: move range/inter diff at the end of a single patch output
Date: Wed, 29 May 2024 07:29:31 -0700 [thread overview]
Message-ID: <xmqqplt41yk4.fsf@gitster.g> (raw)
In-Reply-To: <Zla-GJ6NpSNNVDXq@tanuki> (Patrick Steinhardt's message of "Wed, 29 May 2024 07:33:12 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> On Tue, May 28, 2024 at 09:50:43AM -0700, Junio C Hamano wrote:
>> Patrick Steinhardt <ps@pks.im> writes:
>>
>> > Yeah, that's definitely better. Whether it's preferable over having it
>> > after the signature separator I don't know. I personally liked that
>> > version better, but can totally see why others may not like it.
>>
>> I do not think anybody posted a version that writes inter/range diff
>> ater the signature mark.
>
> No, I'm talking about the version that you hand crafted initially and
> that kicked off this topic.
Ah, https://lore.kernel.org/git/xmqqh6ep1pwz.fsf_-_@gitster.g/ I
forgot all about it already ;-).
> ... I just don't have a strong preference between the old and
> new formats by now. If you or others feel strongly I don't mind at all
> if this patch lands.
Let's scrap it then. I do not think a single-patch topic happens
all that often anyway.
next prev parent reply other threads:[~2024-05-29 14:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 22:50 [PATCH 0/2] give range-diff at the end of single patch output Junio C Hamano
2024-05-23 22:50 ` [PATCH 1/2] show_log: factor out interdiff/range-diff generation Junio C Hamano
2024-05-23 22:50 ` [PATCH 2/2] format-patch: move range/inter diff at the end of a single patch output Junio C Hamano
2024-05-24 11:14 ` Patrick Steinhardt
2024-05-24 21:46 ` Junio C Hamano
2024-05-27 5:19 ` Patrick Steinhardt
2024-05-27 12:59 ` Dragan Simic
2024-05-27 17:43 ` Junio C Hamano
2024-05-28 13:27 ` Patrick Steinhardt
2024-05-28 16:50 ` Junio C Hamano
2024-05-29 5:33 ` Patrick Steinhardt
2024-05-29 14:29 ` Junio C Hamano [this message]
2024-05-30 20:05 ` Dragan Simic
2024-05-24 23:02 ` [PATCH v2 " Junio C Hamano
2024-05-23 23:22 ` [PATCH 0/2] give range-diff at the end of " Dragan Simic
2024-05-23 23:25 ` Junio C Hamano
2024-05-23 23:35 ` Dragan Simic
2024-05-24 3:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqplt41yk4.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).