From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: John Cai <johncai86@gmail.com>,
John Cai via GitGitGadget <gitgitgadget@gmail.com>,
Jonathan Tan <jonathantanmy@google.com>,
git@vger.kernel.org
Subject: Re: [PATCH v3 0/2] index-pack: fsck honor checks
Date: Mon, 29 Jan 2024 09:18:56 -0800 [thread overview]
Message-ID: <xmqqplxkjbwf.fsf@gitster.g> (raw)
In-Reply-To: <ZbeI0ksoUQEkbt90@tanuki> (Patrick Steinhardt's message of "Mon, 29 Jan 2024 12:15:30 +0100")
Patrick Steinhardt <ps@pks.im> writes:
> I'm always a bit hesitant to add trailers referring to off-list reviews
> to commits. It's impossible for a future reader to discover how that
> trailer came to be by just using the mailing list archive, and expecting
> them to use third-party services to verify them feels wrong to me.
>
> It's part of the reason why I'm pushing more into the direction of
> on-list reviews at GitLab. It makes it a lot more obvious how such a
> Reviewed-by came to be and keeps things self-contained on the mailing
> list. It also grows new contributors who are becoming more familiar with
> how the Git mailing list works. If such a review already happened
> internally due to whatever reason then I think it ought to be fine for
> that reviewer to chime in saying that they have already reviewed the
> patch series and that things look good to them.
Thanks. That would improve clarifying a situation like this one
(eh, actually, once it is done this particular situation wouldn't
need any clarification).
next prev parent reply other threads:[~2024-01-29 17:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 20:51 [PATCH 0/2] index-pack: fsck honor checks John Cai via GitGitGadget
2024-01-25 20:51 ` [PATCH 1/2] index-pack: test and document --strict=<msg> John Cai via GitGitGadget
2024-01-25 22:46 ` Junio C Hamano
2024-01-25 20:51 ` [PATCH 2/2] index-pack: --fsck-objects to take an optional argument for fsck msgs John Cai via GitGitGadget
2024-01-25 23:13 ` Junio C Hamano
2024-01-26 17:12 ` [PATCH v2 0/2] index-pack: fsck honor checks John Cai via GitGitGadget
2024-01-26 17:12 ` [PATCH v2 1/2] index-pack: test and document --strict=<msg> John Cai via GitGitGadget
2024-01-26 18:03 ` Junio C Hamano
2024-01-26 17:13 ` [PATCH v2 2/2] index-pack: --fsck-objects to take an optional argument for fsck msgs John Cai via GitGitGadget
2024-01-26 18:13 ` Junio C Hamano
2024-01-26 20:18 ` John Cai
2024-01-26 20:59 ` [PATCH v3 0/2] index-pack: fsck honor checks John Cai via GitGitGadget
2024-01-26 20:59 ` [PATCH v3 1/2] index-pack: test and document --strict=<msg-id>=<severity> John Cai via GitGitGadget
2024-01-26 20:59 ` [PATCH v3 2/2] index-pack: --fsck-objects to take an optional argument for fsck msgs John Cai via GitGitGadget
2024-01-26 21:18 ` [PATCH v3 0/2] index-pack: fsck honor checks Junio C Hamano
2024-01-26 22:11 ` John Cai
2024-01-29 11:15 ` Patrick Steinhardt
2024-01-29 17:18 ` Junio C Hamano [this message]
2024-01-26 22:13 ` Jonathan Tan
2024-01-27 2:31 ` John Cai
2024-01-31 22:30 ` Jonathan Tan
2024-02-01 1:34 ` John Cai
2024-02-01 16:44 ` Junio C Hamano
2024-02-01 1:38 ` [PATCH v4 " John Cai via GitGitGadget
2024-02-01 1:38 ` [PATCH v4 1/2] index-pack: test and document --strict=<msg-id>=<severity> John Cai via GitGitGadget
2024-02-01 1:38 ` [PATCH v4 2/2] index-pack: --fsck-objects to take an optional argument for fsck msgs John Cai via GitGitGadget
2024-03-08 22:24 ` SZEDER Gábor
2024-03-09 1:55 ` John Cai
2024-02-02 15:48 ` [PATCH v4 0/2] index-pack: fsck honor checks Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqplxkjbwf.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johncai86@gmail.com \
--cc=jonathantanmy@google.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).