From: Junio C Hamano <gitster@pobox.com>
To: "Øystein Walle" <oystwa@gmail.com>
Cc: git@vger.kernel.org, derrickstolee@github.com
Subject: Re: [PATCH] revision: Don't queue uninteresting commits
Date: Wed, 11 Oct 2023 09:40:03 -0700 [thread overview]
Message-ID: <xmqqpm1lnme4.fsf@gitster.g> (raw)
In-Reply-To: <20231011123534.119994-1-oystwa@gmail.com> ("Øystein Walle"'s message of "Wed, 11 Oct 2023 14:35:34 +0200")
Øystein Walle <oystwa@gmail.com> writes:
> Currently all given commits are added to the topo_queue during
> init_topo_walk(). Later on in get_revision_1() the uninteresting ones
> are skipped because simplify_commit() tells it to.
>
> Let's not add them to the topo_queue in the first place.
What is not described here is what benefit we are expecting to gain
by making this change. Is anything leaking? Are we showing wrong
output? Is the effect something we can demonstrate, and more
importantly we can protect from future breakages, with a test or
two?
next prev parent reply other threads:[~2023-10-11 16:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 12:35 [PATCH] revision: Don't queue uninteresting commits Øystein Walle
2023-10-11 16:40 ` Junio C Hamano [this message]
2023-11-06 11:28 ` Øystein Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpm1lnme4.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=oystwa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).